Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update snapshots after fix in the wrapping + newline support #68

Merged
merged 11 commits into from
Oct 17, 2023
Merged

Update snapshots after fix in the wrapping + newline support #68

merged 11 commits into from
Oct 17, 2023

Conversation

Melkiades
Copy link
Contributor

No description provided.

@Melkiades Melkiades added the sme label Oct 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023 •
edited
Loading

Unit Tests Summary

    1 files  112 suites   3m 38s ⏱️
249 tests 238 ✔️   11 💤 0 ❌
502 runs  254 ✔️ 248 💤 0 ❌

Results for commit 39c3226.

♻️ This comment has been updated with latest results.

Melkiades
Melkiades commented Oct 16, 2023
View reviewed changes
tests/testthat/_snaps/pagination_table.md Outdated
Comment on lines 206 to 209
A: Drug B: C: Combina
X Placebo tion
SOME
TOPLEFT (N=134) (N=134) (N=132)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to check

@Melkiades
Update tests/testthat/test-pagination_table.R
39c3226 
Signed-off-by: Davide Garolini <dgarolini@gmail.com>
ayogasekaram
ayogasekaram reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@ayogasekaram ayogasekaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes look great Davide!

edelarua
edelarua approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look great! Thanks!!

@anajens anajens self-requested a review October 17, 2023 13:47
anajens
anajens approved these changes Oct 17, 2023
View reviewed changes
Copy link

@anajens anajens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 I think the bottom alignment makes it nicer to read the table headings.

@Melkiades Melkiades merged commit ea78cb4 into main Oct 17, 2023
24 checks passed
@Melkiades Melkiades deleted the update_snaps@208_support_for_newline@main branch October 17, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayogasekaram ayogasekaram ayogasekaram left review comments

@anajens anajens anajens approved these changes

@edelarua edelarua edelarua approved these changes

Assignees
No one assigned
Labels
priority sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Melkiades @anajens @edelarua @ayogasekaram @shajoezhu