-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning for missing p-value in tabulate_rsp_subgroups()
output
#1296
Conversation
Unit Tests Summary 1 files 83 suites 1m 10s ⏱️ Results for commit 8fff63f. ♻️ This comment has been updated with latest results. |
Unit Test Performance DifferenceAdditional test case details
Results for commit f5958e0 ♻️ This comment has been updated with latest results. |
Code Coverage Summary
Diff against main
Results for commit: 8fff63f Minimum allowed coverage is ♻️ This comment has been updated with latest results |
tabulate_rsp_subgroups()
outputtabulate_rsp_subgroups()
output
Signed-off-by: Emily de la Rua <59304861+edelarua@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Thanks Emily ;)
Pull Request
Fixes #1289
I tested out setting the default to
"chisq"
but this would result in a lot ofChi-squared approximation may be incorrect
warnings fortern
and downstream packages so reverted that change. I think the warning should be informative enough, but let me know what you think!