Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added "fraction" statistic to the "analyze_var_count" method group #1309

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

kpagacz
Copy link
Contributor

@kpagacz kpagacz commented Sep 16, 2024

Hello,

I wanted to display the count statistic in roughly this format: xx / xx (xx.xx%), but it's impossible to use analyze_vars in this manner. I could implement my own analyze_vars and the associated functions, but I only need this slight change in the code, and copying the whole thing seems like an overkill.

Let me know if there's a more straightforward solution to display these statistics using the existing API (and not lose the S3 dispatch on different types of input variables).

@shajoezhu @pawelru @gogonzo If you can point me to the correct person to approach regarding this, I'd be grateful.

Copy link
Contributor

github-actions bot commented Sep 16, 2024

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@kpagacz
Copy link
Contributor Author

kpagacz commented Sep 16, 2024

I have read the CLA Document and I hereby sign the CLA

@pawelru
Copy link
Contributor

pawelru commented Sep 16, 2024

@kpagacz please add NEWS entry and fix the tests. Please ignore CLA bot for a while - it's a known issue.

@insightsengineering/nest-sme please kindly help with the review of this

Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! As mentioned, add news and fix tests. Thanks @kpagacz!!

NEWS.md Show resolved Hide resolved
Signed-off-by: Konrad Pagacz <konrad.pagacz@gmail.com>
@gogonzo gogonzo enabled auto-merge (squash) September 17, 2024 07:59
@gogonzo gogonzo merged commit d76a95c into insightsengineering:main Sep 17, 2024
27 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants