Add ADAL01 #38
Closed
Add ADAL01 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @edelarua , I think we need to hold this off until adab is refactored. @qiliu1013 , what do you think? |
|
hi @qiliu1013 , can you take a look at this template please? Thanks! |
Closes #58 --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
follow up on #62 --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Franciszek Walkowiak <franciszek.walkowiak@roche.com> Co-authored-by: go_gonzo <dawid.kaledkowski@gmail.com>
the docs build on main failed - this PR aims to fix it
Partially addresses #74 ### Scope of this PR * Adds the main logic for the snapshot tests for markdown files (tables and listings) * Implement snapshot tests for `tables/adverse-events/aet04.qmd` and `tables/adverse-events/aet04_pi.qmd`. --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Melkiades <davide.garolini@roche.com>
closes #68 --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
test with openpharma/staged.dependencies#182 --------- Signed-off-by: Pawel Rucki <12943682+pawelru@users.noreply.github.com>
currently failing on main: https://github.com/insightsengineering/tlg-catalog/actions/runs/5761645123/job/15619877264#step:6:1614 ``` [ 72/142] tables/safety/vst02.qmd processing file: vst02.qmd 1/16 2/16 [knitr_utils] 3/16 4/16 [setup] 5/16 6/16 [variant1] 7/16 8/16 [variant2] 9/16 [save testenv] 10/16 11/16 [teal] Quitting from lines 85-127 [teal] (vst02.qmd) Error in `x$check_reproducibility()`: ! Reproducibility check failed. Backtrace: 1. teal::init(...) 3. teal.data::cdisc_data(...) 4. x$check_reproducibility() Execution halted ``` --------- Signed-off-by: Pawel Rucki <12943682+pawelru@users.noreply.github.com>
Closes #59 and #55 Also fixes indentation in RMPT06 and TTET01 and simplifies `count_patients_with_flags` usage in AE/PK templates. See insightsengineering/scda.test#55 for corresponding snapshot updates of these templates. --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Davide Garolini <davide.garolini@roche.com>
- `teal` lowercase with code formatting - silent `renv::snapshot()` not to produce messages - rename "session info" into "reproducibility": - rename `/book/appendix/session.qmd` into `/book/appendix/reproducibility.qmd` and change the title accordingly - rename `/book/si.qmd` into `/book/repro.qmd` and change all the refs (this is a shortcode type of file)
add a dedicated renv R option to silent its outputs --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Melkiades
reviewed
Aug 22, 2023
There was a problem hiding this comment.
I think this is good to go if we have this design already done @shajoezhu @edelarua
Part of insightsengineering/tern#992 --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
|
hi @edelarua , I was wondering should we also have a snapshot for this too? @qiliu1013 please help to review this PR please. Thanks |
Merged
|
Please refer to #116 for this table - I have opened a new PR due to the restructuring changes in TLG-C since this PR was created. |
shajoezhu
added a commit
that referenced
this pull request
Oct 10, 2024
Work from #38 moved here due to repo restructuring since previous PR was created. Closes #37 --------- Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com> Co-authored-by: Davide Garolini <davide.garolini@roche.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Joe Zhu <sha.joe.zhu@gmail.com> Co-authored-by: Qi Liu <liu.qi@gene.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design completed by Valentin in 2022 but never added to TLG-C.
Closes #37