-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set the action head automatically #1104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swap to using action specs instead of manually making the dictionary of env -> head 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a general suggestion so that we can also use this function for the transformer based systems which don't need a head config but need an action space type.
You'd just also need to update the system run files to accommodate for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you @WiemKhlifi 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
What?
Refactored action head selection to use a dictionary lookup instead of manually setting for each env and network.
Why?
This change eases the process of selecting the appropriate action head for each environment.
How?
Added the
get_action_head
function as a utility and removed theaction_head
from all yaml configs.