-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vdp): add component definition list endpoint #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvallesm
requested review from
heiruwu,
pinglin and
xiaofei-du
as code owners
February 28, 2024 11:58
jvallesm
force-pushed
the
jvalles/ins-3680-create-component-list-endpoint
branch
from
February 28, 2024 14:35
fb26eb1
to
4f7cfe0
Compare
jvallesm
changed the title
feat: add component definition list endpoint
feat(vdp): add component definition list endpoint
Feb 28, 2024
jvallesm
force-pushed
the
jvalles/ins-3680-create-component-list-endpoint
branch
from
February 28, 2024 16:57
4f7cfe0
to
41db0fa
Compare
donch1989
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
heiruwu
approved these changes
Feb 29, 2024
heiruwu
pushed a commit
that referenced
this pull request
Feb 29, 2024
Because - Website needs to access a paginated list of components This commit - Opens the endpoint introduced in instill-ai/protobufs#274
heiruwu
pushed a commit
that referenced
this pull request
Feb 29, 2024
🤖 I have created a release *beep* *boop* --- ## [0.11.0-beta](v0.10.0-beta...v0.11.0-beta) (2024-02-29) ### Features * **vdp:** add component definition list endpoint ([#137](#137)) ([8e459b7](8e459b7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
heiruwu
pushed a commit
that referenced
this pull request
Feb 29, 2024
🤖 I have created a release *beep* *boop* --- ## [0.11.0-beta](v0.10.0-beta...v0.11.0-beta) (2024-02-29) ### Features * **vdp:** add component definition list endpoint ([#137](#137)) ([8e459b7](8e459b7)) ### Bug Fixes * **vdp:** implement offset pagination in component list endpoint ([#139](#139)) ([a6b7566](a6b7566)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit