Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vdp): add component definition list endpoint #137

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

jvallesm
Copy link
Contributor

Because

  • Website needs to access a paginated list of components

This commit

@jvallesm jvallesm self-assigned this Feb 28, 2024
Copy link

linear bot commented Feb 28, 2024

@jvallesm jvallesm force-pushed the jvalles/ins-3680-create-component-list-endpoint branch from fb26eb1 to 4f7cfe0 Compare February 28, 2024 14:35
@jvallesm jvallesm changed the title feat: add component definition list endpoint feat(vdp): add component definition list endpoint Feb 28, 2024
@jvallesm jvallesm requested a review from donch1989 February 28, 2024 15:00
@jvallesm jvallesm force-pushed the jvalles/ins-3680-create-component-list-endpoint branch from 4f7cfe0 to 41db0fa Compare February 28, 2024 16:57
Copy link
Member

@donch1989 donch1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heiruwu heiruwu merged commit d3748ef into main Feb 29, 2024
11 checks passed
@heiruwu heiruwu deleted the jvalles/ins-3680-create-component-list-endpoint branch February 29, 2024 05:09
heiruwu pushed a commit that referenced this pull request Feb 29, 2024
Because

- Website needs to access a paginated list of components

This commit

- Opens the endpoint introduced in
instill-ai/protobufs#274
heiruwu pushed a commit that referenced this pull request Feb 29, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.11.0-beta](v0.10.0-beta...v0.11.0-beta)
(2024-02-29)


### Features

* **vdp:** add component definition list endpoint
([#137](#137))
([8e459b7](8e459b7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
heiruwu pushed a commit that referenced this pull request Feb 29, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.11.0-beta](v0.10.0-beta...v0.11.0-beta)
(2024-02-29)


### Features

* **vdp:** add component definition list endpoint
([#137](#137))
([8e459b7](8e459b7))


### Bug Fixes

* **vdp:** implement offset pagination in component list endpoint
([#139](#139))
([a6b7566](a6b7566))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: 👋 Done
Development

Successfully merging this pull request may close these issues.

4 participants