Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(registry): add registry proxy plugin #143

Conversation

pinglin
Copy link
Member

@pinglin pinglin commented Mar 15, 2024

Because

  • Instill Artifact is going to have a OCI-compatible artifact registry service!

This commit

  • implement a KrakenD plugin for the registry proxy

Copy link

linear bot commented Mar 15, 2024

@pinglin pinglin force-pushed the pinglin/ins-3906-implement-the-corresponding-api-gateway-routing-to-the branch from b36159c to f77f5c1 Compare March 15, 2024 00:46
Copy link
Contributor

@jvallesm jvallesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! 💪

❓ I have some questions to make sure I'm understanding the design.

  • How will the configuration look like to point to the model registry?
  • And when we have model and pipeline registries?
  • Do you have some sort of end-to-end diagram illustrating what we're trying to achieve with this plugin? It will be helpful to make sure we're aligned on the design.

registry-plugin/main.go Outdated Show resolved Hide resolved
registry-plugin/main.go Outdated Show resolved Hide resolved
@pinglin
Copy link
Member Author

pinglin commented Mar 15, 2024

  • How will the configuration look like to point to the model registry?

It should be as simple as specifying the registry network address by setting the corresponding api-gateway environment variables.

  • And when we have model and pipeline registries?

We are going to have model registry first. This is crucial to support the new model containerisation design which @heiruwu and @tonywang10101 are working on.

  • Do you have some sort of end-to-end diagram illustrating what we're trying to achieve with this plugin? It will be helpful to make sure we're aligned on the design.

A very high-level architecture looks like this:

image

@pinglin pinglin force-pushed the pinglin/ins-3906-implement-the-corresponding-api-gateway-routing-to-the branch from 899524a to 0aec912 Compare March 15, 2024 20:35
@pinglin pinglin force-pushed the pinglin/ins-3906-implement-the-corresponding-api-gateway-routing-to-the branch from 0aec912 to 1ff2fe0 Compare March 15, 2024 20:43
@pinglin pinglin force-pushed the pinglin/ins-3906-implement-the-corresponding-api-gateway-routing-to-the branch from 1ff2fe0 to 425aedf Compare March 15, 2024 20:58
@pinglin pinglin force-pushed the pinglin/ins-3906-implement-the-corresponding-api-gateway-routing-to-the branch from 425aedf to 699bdd6 Compare March 15, 2024 21:33
@pinglin pinglin force-pushed the pinglin/ins-3906-implement-the-corresponding-api-gateway-routing-to-the branch from 699bdd6 to 8e1231c Compare March 15, 2024 21:44
pinglin and others added 2 commits March 15, 2024 22:00
@pinglin pinglin force-pushed the pinglin/ins-3906-implement-the-corresponding-api-gateway-routing-to-the branch 3 times, most recently from bf843ee to a43434e Compare March 16, 2024 01:24
@pinglin pinglin force-pushed the pinglin/ins-3906-implement-the-corresponding-api-gateway-routing-to-the branch from a43434e to 15b881c Compare March 16, 2024 01:25
registry-plugin/main.go Dismissed Show dismissed Hide dismissed
@pinglin pinglin force-pushed the pinglin/ins-3906-implement-the-corresponding-api-gateway-routing-to-the branch from 14e6ee5 to a9e2450 Compare March 18, 2024 13:33
@pinglin pinglin merged commit 97c280c into main Mar 18, 2024
23 checks passed
@pinglin pinglin deleted the pinglin/ins-3906-implement-the-corresponding-api-gateway-routing-to-the branch March 18, 2024 16:43
Copy link
Contributor

@jvallesm jvallesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review, didn't find time yesterday.

I added some comments, only one requires actual discussion (the username variable not being set).

registry-plugin/main.go Show resolved Hide resolved
registry-plugin/main.go Show resolved Hide resolved
registry-plugin/main.go Show resolved Hide resolved
registry-plugin/main.go Show resolved Hide resolved
heiruwu pushed a commit that referenced this pull request Mar 29, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.12.0-beta](v0.11.0-beta...v0.12.0-beta)
(2024-03-21)


### Features

* **registry:** add registry proxy plugin
([#143](#143))
([97c280c](97c280c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
heiruwu pushed a commit that referenced this pull request Mar 30, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.12.0-beta](v0.11.0-beta...v0.12.0-beta)
(2024-03-30)


### Features

* **registry:** add registry proxy plugin
([#143](#143))
([97c280c](97c280c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants