-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(registry): add registry proxy plugin #143
feat(registry): add registry proxy plugin #143
Conversation
b36159c
to
f77f5c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this! 💪
❓ I have some questions to make sure I'm understanding the design.
- How will the configuration look like to point to the model registry?
- And when we have model and pipeline registries?
- Do you have some sort of end-to-end diagram illustrating what we're trying to achieve with this plugin? It will be helpful to make sure we're aligned on the design.
It should be as simple as specifying the registry network address by setting the corresponding api-gateway environment variables.
We are going to have model registry first. This is crucial to support the new model containerisation design which @heiruwu and @tonywang10101 are working on.
A very high-level architecture looks like this: |
899524a
to
0aec912
Compare
0aec912
to
1ff2fe0
Compare
1ff2fe0
to
425aedf
Compare
425aedf
to
699bdd6
Compare
699bdd6
to
8e1231c
Compare
Co-authored-by: Juan Vallés <3977183+jvallesm@users.noreply.github.com>
bf843ee
to
a43434e
Compare
a43434e
to
15b881c
Compare
14e6ee5
to
a9e2450
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review, didn't find time yesterday.
I added some comments, only one requires actual discussion (the username
variable not being set).
🤖 I have created a release *beep* *boop* --- ## [0.12.0-beta](v0.11.0-beta...v0.12.0-beta) (2024-03-21) ### Features * **registry:** add registry proxy plugin ([#143](#143)) ([97c280c](97c280c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [0.12.0-beta](v0.11.0-beta...v0.12.0-beta) (2024-03-30) ### Features * **registry:** add registry proxy plugin ([#143](#143)) ([97c280c](97c280c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Because
This commit