feat(mgmt): use unified dashboard endpoints #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvallesm
force-pushed
the
jvalles/ins-5379-credit-dashboard-endpoints
branch
from
de750df to
eb8af8c
Compare
jvallesm
force-pushed
the
jvalles/ins-5379-credit-dashboard-endpoints
branch
from
eb8af8c to
7c89141
Compare
jvallesm
requested review from
donch1989,
heiruwu,
pinglin and
xiaofei-du
as code owners
The new path reflects that the endpoint isn't resource-oriented and that it is a custom method.
The gRPC endpoint keeps the old name. Therefore, the previous endpoint is renamed.
jvallesm
force-pushed
the
jvalles/ins-5379-credit-dashboard-endpoints
branch
from
7c89141 to
5ac1791
Compare
heiruwu
approved these changes
Nov 26, 2024
heiruwu
pushed a commit
that referenced
this pull request
Dec 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.31.0-beta](v0.30.0-beta...v0.31.0-beta) (2024-11-29) ### Features * **artifact:** support search chunk & source ([#272](#272)) ([48b7573](48b7573)) * **mgmt:** use unified dashboard endpoints ([#239](#239)) ([1f223b1](1f223b1)) ### Bug Fixes * **blob:** remove auth for using upload and download url ([#269](#269)) ([e262b10](e262b10)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit
feat(mgmt): update metrics endpoints to serve new dashboard design protobufs#435