Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(test): inject variables to instill-core to test OAuth support #264

Merged
merged 1 commit into from
Oct 31, 2024
Merged

chore(test): inject variables to instill-core to test OAuth support #264

merged 1 commit into from
Oct 31, 2024

Conversation

jvallesm
Copy link
Contributor

Because

This commit

  • Adds the environment variable to instill-cloud setup in CI.

@jvallesm jvallesm self-assigned this Oct 31, 2024
@linear Linear
Copy link

linear bot commented Oct 31, 2024

INS-6570 Pass OAuth client and secret IDs to backend and frontend

@jvallesm jvallesm marked this pull request as ready for review October 31, 2024 16:52
@jvallesm jvallesm merged commit 645e14a into main Oct 31, 2024
13 checks passed
@jvallesm jvallesm deleted the jvalles/ins-6570-pass-oauth-client-and-secret-ids-to-backend-and-frontend branch October 31, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donch1989 donch1989 donch1989 approved these changes

@heiruwu heiruwu Awaiting requested review from heiruwu heiruwu is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees

@jvallesm jvallesm

Labels
instill core
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jvallesm @donch1989 @droplet-bot