Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
Yougigun committed Dec 9, 2024
1 parent 5d13734 commit 5bd1adc
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions pkg/handler/knowledgebasefiles.go
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,6 @@ func checkUploadKnowledgeBaseFileRequest(req *artifactpb.UploadCatalogFileReques
return nil
}

// TODO: launch the artifact cloud to test this
// MoveFileToCatalog moves a file from one catalog to another within the same namespace.
// It copies the file content and metadata to the target catalog and deletes
// the file from the source catalog.
Expand Down Expand Up @@ -468,7 +467,7 @@ func (ph *PublicHandler) DeleteCatalogFile(
}

startSignal := make(chan bool)
// TODO: need to use clean worker in the future
// TODO: need to use clean worker to prevent the service from being restarted before the file is deleted
go utils.GoRecover(
func() {
// Create a new context to prevent the parent context from being cancelled
Expand Down

0 comments on commit 5bd1adc

Please sign in to comment.