From 5bd1adcffc458c40c8580fc042dae5f149c976a6 Mon Sep 17 00:00:00 2001 From: "gary.y" Date: Mon, 9 Dec 2024 19:16:48 +0800 Subject: [PATCH] fix --- pkg/handler/knowledgebasefiles.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pkg/handler/knowledgebasefiles.go b/pkg/handler/knowledgebasefiles.go index 7e3c9c7..c6dcf88 100644 --- a/pkg/handler/knowledgebasefiles.go +++ b/pkg/handler/knowledgebasefiles.go @@ -220,7 +220,6 @@ func checkUploadKnowledgeBaseFileRequest(req *artifactpb.UploadCatalogFileReques return nil } -// TODO: launch the artifact cloud to test this // MoveFileToCatalog moves a file from one catalog to another within the same namespace. // It copies the file content and metadata to the target catalog and deletes // the file from the source catalog. @@ -468,7 +467,7 @@ func (ph *PublicHandler) DeleteCatalogFile( } startSignal := make(chan bool) - // TODO: need to use clean worker in the future + // TODO: need to use clean worker to prevent the service from being restarted before the file is deleted go utils.GoRecover( func() { // Create a new context to prevent the parent context from being cancelled