Skip to content

Commit

Permalink
chore: update Golang to 1.22.5 (#48)
Browse files Browse the repository at this point in the history
Because

- We don't want to use environment variables for the Golang vesion.

This commit

- Upgrades the Golang version to 1.22.5.
- Removes unnecessary environment variables.
  • Loading branch information
donch1989 authored Jul 29, 2024
1 parent d1d5345 commit ea8e73d
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .env
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# version
GOLANG_VERSION=1.22
GOLANG_VERSION=1.22.5
K6_VERSION=0.42.0

# service
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
go-version: '1.21'
cache: false
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
uses: golangci/golangci-lint-action@v6
with:
version: v1.54
version: v1.59
args: --timeout=10m
2 changes: 0 additions & 2 deletions .github/workflows/images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ jobs:
push: true
build-args: |
SERVICE_NAME=artifact-backend
GOLANG_VERSION=${{ env.GOLANG_VERSION }}
tags: instill/artifact-backend:latest
cache-from: type=registry,ref=instill/artifact-backend:buildcache
cache-to: type=registry,ref=instill/artifact-backend:buildcache,mode=max
Expand All @@ -61,7 +60,6 @@ jobs:
push: true
build-args: |
SERVICE_NAME=artifact-backend
GOLANG_VERSION=${{ env.GOLANG_VERSION }}
tags: instill/artifact-backend:${{steps.set_version.outputs.no_v_tag}}
cache-from: type=registry,ref=instill/artifact-backend:buildcache
cache-to: type=registry,ref=instill/artifact-backend:buildcache,mode=max
5 changes: 2 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
ARG GOLANG_VERSION
FROM --platform=$TARGETPLATFORM golang:${GOLANG_VERSION} AS build
FROM --platform=$TARGETPLATFORM golang:1.22.5 AS build

WORKDIR /src

Expand All @@ -21,7 +20,7 @@ RUN --mount=type=cache,target=/go/pkg/mod \
GOOS=$TARGETOS GOARCH=$TARGETARCH CGO_ENABLED=0 go build -o /${SERVICE_NAME}-migrate ./cmd/migration


FROM golang:${GOLANG_VERSION}
FROM golang:1.22.5

USER nobody:nogroup

Expand Down
3 changes: 1 addition & 2 deletions Dockerfile.dev
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
ARG GOLANG_VERSION
FROM golang:${GOLANG_VERSION}
FROM golang:1.22.5

ARG SERVICE_NAME

Expand Down
4 changes: 1 addition & 3 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
module github.com/instill-ai/artifact-backend

go 1.22.3

toolchain go1.22.5
go 1.22.5

require (
github.com/frankban/quicktest v1.14.6
Expand Down

0 comments on commit ea8e73d

Please sign in to comment.