Skip to content

Commit

Permalink
chore(helm): update path of probe endpoints (#400)
Browse files Browse the repository at this point in the history
Because

- we've upgrade the endpoints version from `v1alpha` to `v1beta`

This commit

- update path of probe endpoints
  • Loading branch information
donch1989 authored Dec 7, 2023
1 parent 2b01290 commit 0439bb8
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 12 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/make-all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ jobs:
- name: Probe to vdp services healthcheck endpoint
run: |
curl -s -o /dev/null -w ''%{http_code}'\n' http://localhost:8080/core/v1alpha/health/mgmt
curl -s -o /dev/null -w ''%{http_code}'\n' http://localhost:8080/vdp/v1alpha/health/pipeline
curl -s -o /dev/null -w ''%{http_code}'\n' http://localhost:8080/core/v1beta/health/mgmt
curl -s -o /dev/null -w ''%{http_code}'\n' http://localhost:8080/vdp/v1beta/health/pipeline
- name: Tear down Instill VDP (release)
run: |
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/make-latest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,9 @@ jobs:
- name: Curl to vdp services healthcheck endpoint
run: |
curl -s -o /dev/null -w ''%{http_code}'\n' http://localhost:8080/core/v1alpha/health/mgmt
curl -s -o /dev/null -w ''%{http_code}'\n' http://localhost:8080/vdp/v1alpha/health/pipeline
curl -s -o /dev/null -w ''%{http_code}'\n' http://localhost:3085/v1alpha/health/controller
curl -s -o /dev/null -w ''%{http_code}'\n' http://localhost:8080/core/v1beta/health/mgmt
curl -s -o /dev/null -w ''%{http_code}'\n' http://localhost:8080/vdp/v1beta/health/pipeline
curl -s -o /dev/null -w ''%{http_code}'\n' http://localhost:3085/v1beta/health/controller
- name: Tear down Instill VDP (latest)
run: |
Expand Down
8 changes: 4 additions & 4 deletions charts/vdp/templates/controller-vdp/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ spec:
args:
- >
while [[ "$(curl -s -o /dev/null -w ''%{http_code}'' ${ETCD_HOST}:${ETCD_CLIENT_PORT}/health)" != "200" ]]; do echo waiting for etcd; sleep 1; done &&
while [[ "$(curl -s -o /dev/null -w ''%{http_code}'' ${PIPELINE_BACKEND_HOST}:${PIPELINE_BACKEND_PORT}/v1alpha/health/pipeline)" != "200" ]]; do echo waiting for pipeline-backend; sleep 1; done &&
while [[ "$(curl -s -o /dev/null -w ''%{http_code}'' ${MGMT_BACKEND_HOST}:${MGMT_BACKEND_PORT}/v1alpha/health/mgmt)" != "200" ]]; do echo waiting for mgmt-backend; sleep 1; done
while [[ "$(curl -s -o /dev/null -w ''%{http_code}'' ${PIPELINE_BACKEND_HOST}:${PIPELINE_BACKEND_PORT}/v1beta/health/pipeline)" != "200" ]]; do echo waiting for pipeline-backend; sleep 1; done &&
while [[ "$(curl -s -o /dev/null -w ''%{http_code}'' ${MGMT_BACKEND_HOST}:${MGMT_BACKEND_PORT}/v1beta/health/mgmt)" != "200" ]]; do echo waiting for mgmt-backend; sleep 1; done
env:
- name: PIPELINE_BACKEND_HOST
value: "{{ template "vdp.pipelineBackend" . }}"
Expand All @@ -72,14 +72,14 @@ spec:
imagePullPolicy: {{ .Values.controllerVDP.image.pullPolicy }}
readinessProbe:
httpGet:
path: /v1alpha/__readiness
path: /v1beta/__readiness
scheme: {{ ternary "https" "http" .Values.internalTLS.enabled | upper }}
port: {{ ternary "https" "http" .Values.internalTLS.enabled }}-private
initialDelaySeconds: 5
periodSeconds: 10
livenessProbe:
httpGet:
path: /v1alpha/__liveness
path: /v1beta/__liveness
scheme: {{ ternary "https" "http" .Values.internalTLS.enabled | upper }}
port: {{ ternary "https" "http" .Values.internalTLS.enabled }}-private
initialDelaySeconds: 5
Expand Down
6 changes: 3 additions & 3 deletions charts/vdp/templates/pipeline-backend/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ spec:
command: ['sh', '-c']
args:
- >
while [[ "$(curl -s -o /dev/null -w ''%{http_code}'' ${MGMT_BACKEND_HOST}:${MGMT_BACKEND_PORT}/v1alpha/health/mgmt)" != "200" ]]; do echo waiting for mgmt-backend; sleep 1; done
while [[ "$(curl -s -o /dev/null -w ''%{http_code}'' ${MGMT_BACKEND_HOST}:${MGMT_BACKEND_PORT}/v1beta/health/mgmt)" != "200" ]]; do echo waiting for mgmt-backend; sleep 1; done
env:
- name: MGMT_BACKEND_HOST
value: "{{ template "core.mgmtBackend" . }}"
Expand Down Expand Up @@ -197,14 +197,14 @@ spec:
imagePullPolicy: {{ .Values.pipelineBackend.image.pullPolicy }}
readinessProbe:
httpGet:
path: /v1alpha/__readiness
path: /v1beta/__readiness
scheme: {{ ternary "https" "http" .Values.internalTLS.enabled | upper }}
port: {{ ternary "https" "http" .Values.internalTLS.enabled }}-public
initialDelaySeconds: 5
periodSeconds: 10
livenessProbe:
httpGet:
path: /v1alpha/__liveness
path: /v1beta/__liveness
scheme: {{ ternary "https" "http" .Values.internalTLS.enabled | upper }}
port: {{ ternary "https" "http" .Values.internalTLS.enabled }}-public
initialDelaySeconds: 5
Expand Down

0 comments on commit 0439bb8

Please sign in to comment.