Skip to content

Commit

Permalink
chore(helm): add rolling update strategy (#398)
Browse files Browse the repository at this point in the history
Because

- we need to add the maxSurge and maxUnavailable values into the
deployment

This commit

- add rolling update strategy
  • Loading branch information
Sarthak-instill authored Dec 15, 2023
1 parent 9d56fca commit 1dcb0c7
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 2 deletions.
6 changes: 5 additions & 1 deletion charts/vdp/templates/controller-vdp/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ metadata:
spec:
strategy:
type: {{ .Values.updateStrategy.type }}
{{- if eq .Values.updateStrategy.type "Recreate" }}
{{- if eq .Values.updateStrategy.type "RollingUpdate" }}
rollingUpdate:
maxSurge: {{ .Values.updateStrategy.rollingUpdate.maxSurge }}
maxUnavailable: {{ .Values.updateStrategy.rollingUpdate.maxUnavailable }}
{{- else}}
rollingUpdate: null
{{- end }}
{{- if not .Values.controllerVDP.autoscaling.enabled }}
Expand Down
6 changes: 5 additions & 1 deletion charts/vdp/templates/pipeline-backend/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@ metadata:
spec:
strategy:
type: {{ .Values.updateStrategy.type }}
{{- if eq .Values.updateStrategy.type "Recreate" }}
{{- if eq .Values.updateStrategy.type "RollingUpdate" }}
rollingUpdate:
maxSurge: {{ .Values.updateStrategy.rollingUpdate.maxSurge }}
maxUnavailable: {{ .Values.updateStrategy.rollingUpdate.maxUnavailable }}
{{- else}}
rollingUpdate: null
{{- end }}
{{- if not .Values.pipelineBackend.autoscaling.enabled }}
Expand Down
3 changes: 3 additions & 0 deletions charts/vdp/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ fullnameOverride: ""
# Set it as "Recreate" when "RWM" for volumes isn't supported
updateStrategy:
type: RollingUpdate
rollingUpdate:
maxSurge: 1
maxUnavailable: 0
# -- Logging level: debug, info, warning, error or fatal
logLevel: info
# -- Enable development mode
Expand Down

0 comments on commit 1dcb0c7

Please sign in to comment.