Skip to content

Commit

Permalink
fix(helm): pass OAuth configuration variables on integration tests (#…
Browse files Browse the repository at this point in the history
…1151)

Because

- instill-ai/pipeline-backend#799 commented out
some checks in `pipeline-backend`'s integration tests because they
depended on some environment variables that the Helm charts weren't
passing.

This commit

- Pass the required OAuth client variables so the full
`pipeline-backend` suite can be run.
  • Loading branch information
jvallesm authored Nov 8, 2024
1 parent 7f4da14 commit 2c235d5
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
11 changes: 11 additions & 0 deletions .github/workflows/helm-integration-test-backend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ jobs:
xk6 build v${{ env.K6_VERSION }} --with github.com/grafana/xk6-sql@v0.4.1 && sudo cp k6 /usr/bin
- name: Launch Helm Instill Core (${{ inputs.target }})
# Dummy GitHub OAuth configuration variables are inserted on
# `pipeline-backend` because tests in this service rely on the
# integration to be configured.
run: |
if [ "${{ inputs.target }}" == "latest" ]; then
helm install core charts/core --namespace instill-ai --create-namespace \
Expand All @@ -60,6 +63,10 @@ jobs:
--set apiGateway.image.tag=latest \
--set mgmtBackend.image.tag=latest \
--set pipelineBackend.image.tag=latest \
--set 'pipelineBackend.extraEnv[0].name=CFG_COMPONENT_SECRETS_GITHUB_OAUTHCLIENTID' \
--set 'pipelineBackend.extraEnv[0].value=dummy' \
--set 'pipelineBackend.extraEnv[1].name=CFG_COMPONENT_SECRETS_GITHUB_OAUTHCLIENTSECRET' \
--set 'pipelineBackend.extraEnv[1].value=dummy' \
--set modelBackend.image.tag=latest \
--set console.image.tag=latest \
--set rayService.image.tag=latest \
Expand Down Expand Up @@ -90,6 +97,10 @@ jobs:
--set mgmtBackend.instillCoreHost=http://${INSTILL_CORE_HOST}:${API_GATEWAY_PORT} \
--set pipelineBackend.image.tag=${PIPELINE_BACKEND_VERSION} \
--set pipelineBackend.instillCoreHost=http://${INSTILL_CORE_HOST}:${API_GATEWAY_PORT} \
--set 'pipelineBackend.extraEnv[0].name=CFG_COMPONENT_SECRETS_GITHUB_OAUTHCLIENTID' \
--set 'pipelineBackend.extraEnv[0].value=dummy' \
--set 'pipelineBackend.extraEnv[1].name=CFG_COMPONENT_SECRETS_GITHUB_OAUTHCLIENTSECRET' \
--set 'pipelineBackend.extraEnv[1].value=dummy' \
--set modelBackend.instillCoreHost=http://${INSTILL_CORE_HOST}:${API_GATEWAY_PORT} \
--set modelBackend.image.tag=${MODEL_BACKEND_VERSION} \
--set console.image.tag=${CONSOLE_VERSION} \
Expand Down
2 changes: 1 addition & 1 deletion charts/core/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ the latest versions of the packages. You can then run `helm search repo vdp --de
To install the chart (alpha version):

```bash
helm install <release-name> instill-ai/vdp --devel
helm install <release-name> instill-ai/core --devel --namespace instill-ai --create-namespace
```

## Uninstall
Expand Down

0 comments on commit 2c235d5

Please sign in to comment.