From 2c235d505928d89cf0dc3493826760df32dce57c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juan=20Vall=C3=A9s?=
 <3977183+jvallesm@users.noreply.github.com>
Date: Fri, 8 Nov 2024 17:07:08 +0100
Subject: [PATCH] fix(helm): pass OAuth configuration variables on integration
 tests (#1151)

Because

- https://github.com/instill-ai/pipeline-backend/pull/799 commented out
some checks in `pipeline-backend`'s integration tests because they
depended on some environment variables that the Helm charts weren't
passing.

This commit

- Pass the required OAuth client variables so the full
`pipeline-backend` suite can be run.
---
 .github/workflows/helm-integration-test-backend.yml | 11 +++++++++++
 charts/core/README.md                               |  2 +-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/helm-integration-test-backend.yml b/.github/workflows/helm-integration-test-backend.yml
index 7b51b3e0..c734f353 100644
--- a/.github/workflows/helm-integration-test-backend.yml
+++ b/.github/workflows/helm-integration-test-backend.yml
@@ -52,6 +52,9 @@ jobs:
           xk6 build v${{ env.K6_VERSION }} --with github.com/grafana/xk6-sql@v0.4.1 && sudo cp k6 /usr/bin
 
       - name: Launch Helm Instill Core (${{ inputs.target }})
+        # Dummy GitHub OAuth configuration variables are inserted on
+        # `pipeline-backend` because tests in this service rely on the
+        # integration to be configured.
         run: |
           if [ "${{ inputs.target }}" == "latest" ]; then
             helm install core charts/core --namespace instill-ai --create-namespace \
@@ -60,6 +63,10 @@ jobs:
               --set apiGateway.image.tag=latest \
               --set mgmtBackend.image.tag=latest \
               --set pipelineBackend.image.tag=latest \
+              --set 'pipelineBackend.extraEnv[0].name=CFG_COMPONENT_SECRETS_GITHUB_OAUTHCLIENTID' \
+              --set 'pipelineBackend.extraEnv[0].value=dummy' \
+              --set 'pipelineBackend.extraEnv[1].name=CFG_COMPONENT_SECRETS_GITHUB_OAUTHCLIENTSECRET' \
+              --set 'pipelineBackend.extraEnv[1].value=dummy' \
               --set modelBackend.image.tag=latest \
               --set console.image.tag=latest \
               --set rayService.image.tag=latest \
@@ -90,6 +97,10 @@ jobs:
               --set mgmtBackend.instillCoreHost=http://${INSTILL_CORE_HOST}:${API_GATEWAY_PORT} \
               --set pipelineBackend.image.tag=${PIPELINE_BACKEND_VERSION} \
               --set pipelineBackend.instillCoreHost=http://${INSTILL_CORE_HOST}:${API_GATEWAY_PORT} \
+              --set 'pipelineBackend.extraEnv[0].name=CFG_COMPONENT_SECRETS_GITHUB_OAUTHCLIENTID' \
+              --set 'pipelineBackend.extraEnv[0].value=dummy' \
+              --set 'pipelineBackend.extraEnv[1].name=CFG_COMPONENT_SECRETS_GITHUB_OAUTHCLIENTSECRET' \
+              --set 'pipelineBackend.extraEnv[1].value=dummy' \
               --set modelBackend.instillCoreHost=http://${INSTILL_CORE_HOST}:${API_GATEWAY_PORT} \
               --set modelBackend.image.tag=${MODEL_BACKEND_VERSION} \
               --set console.image.tag=${CONSOLE_VERSION} \
diff --git a/charts/core/README.md b/charts/core/README.md
index 19a42e51..2affae01 100644
--- a/charts/core/README.md
+++ b/charts/core/README.md
@@ -31,7 +31,7 @@ the latest versions of the packages. You can then run `helm search repo vdp --de
 To install the chart (alpha version):
 
 ```bash
-helm install <release-name> instill-ai/vdp --devel
+helm install <release-name> instill-ai/core --devel --namespace instill-ai --create-namespace
 ```
 
 ## Uninstall