Skip to content

Commit

Permalink
chore(makefile): fix latest integration-test (#488)
Browse files Browse the repository at this point in the history
Because

- local integration-test-latest won't pass

This commit

- fix model-backend tag after `build-latest`
- make ray server image tag fixed temporary
  • Loading branch information
heiruwu authored Apr 22, 2024
1 parent 7f3af40 commit 927f0e2
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ build-latest: ## Build latest images for all Instill Core components
API_GATEWAY_VERSION=latest \
MGMT_BACKEND_VERSION=latest \
PIPELINE_BACKEND_VERSION=latest \
MODEL_BACKEND_VERSION=${MODEL_BACKEND_VERSION} \
MODEL_BACKEND_VERSION=latest \
ARTIFACT_BACKEND_VERSION=latest \
CONSOLE_VERSION=latest \
COMPOSE_PROFILES=${PROFILE} docker compose -f docker-compose-build.yml build --progress plain \
Expand Down Expand Up @@ -220,7 +220,7 @@ helm-integration-test-latest: ## Run integration test on t
--set pipelineBackend.excludelocalconnector=false \
--set modelBackend.image.tag=${MODEL_BACKEND_VERSION} \
--set console.image.tag=latest \
--set rayService.image.tag=${RAY_LATEST_TAG} \
--set rayService.image.tag=${RAY_RELEASE_TAG} \
--set tags.observability=false \
--set tags.prometheusStack=false
@kubectl rollout status deployment ${HELM_RELEASE_NAME}-api-gateway --namespace ${HELM_NAMESPACE} --timeout=300s
Expand Down Expand Up @@ -338,7 +338,7 @@ ifeq ($(UNAME_S),Darwin)
--set pipelineBackend.excludelocalconnector=false \
--set modelBackend.image.tag=${MODEL_BACKEND_VERSION} \
--set console.image.tag=latest \
--set rayService.image.tag=${RAY_LATEST_TAG} \
--set rayService.image.tag=${RAY_RELEASE_TAG} \
--set apiGatewayURL=http://host.docker.internal:${API_GATEWAY_PORT} \
--set console.serverApiGatewayURL=http://host.docker.internal:${API_GATEWAY_PORT} \
--set consoleURL=http://host.docker.internal:${CONSOLE_PORT}
Expand All @@ -356,7 +356,7 @@ else ifeq ($(UNAME_S),Linux)
--set pipelineBackend.excludelocalconnector=false \
--set modelBackend.image.tag=${MODEL_BACKEND_VERSION} \
--set console.image.tag=latest \
--set rayService.image.tag=${RAY_LATEST_TAG} \
--set rayService.image.tag=${RAY_RELEASE_TAG} \
--set apiGatewayURL=http://localhost:${API_GATEWAY_PORT} \
--set console.serverApiGatewayURL=http://localhost:${API_GATEWAY_PORT} \
--set consoleURL=http://localhost:${CONSOLE_PORT}
Expand Down
2 changes: 1 addition & 1 deletion docker-compose-latest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ services:
- ${TEMPORAL_PORT}:7233

ray_server:
image: ${RAY_SERVER_IMAGE}:${RAY_LATEST_TAG}
image: ${RAY_SERVER_IMAGE}:${RAY_RELEASE_TAG}
ports:
- ${RAY_SERVER_CLIENT_PORT}:${RAY_SERVER_CLIENT_PORT}
- ${RAY_SERVER_DASHBOARD_PORT}:${RAY_SERVER_DASHBOARD_PORT}
Expand Down

0 comments on commit 927f0e2

Please sign in to comment.