From c14933934faa5a70dbfc11ac893aade71e551f15 Mon Sep 17 00:00:00 2001
From: "gary.y" <s14031403@gmail.com>
Date: Wed, 5 Jun 2024 18:25:36 +0800
Subject: [PATCH] chore(milvus): add toggele on milvus

---
 charts/core/Chart.yaml  | 1 +
 charts/core/values.yaml | 8 ++++----
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/charts/core/Chart.yaml b/charts/core/Chart.yaml
index 9ab0faf9..204bf1ec 100644
--- a/charts/core/Chart.yaml
+++ b/charts/core/Chart.yaml
@@ -21,6 +21,7 @@ dependencies:
   - name: milvus
     repository: https://zilliztech.github.io/milvus-helm/
     version: 4.1.30
+    condition: artifactBackend.enabled
   - name: kuberay-operator
     repository: https://ray-project.github.io/kuberay-helm/
     version: 1.1.1
diff --git a/charts/core/values.yaml b/charts/core/values.yaml
index fe9c26b1..8029409a 100644
--- a/charts/core/values.yaml
+++ b/charts/core/values.yaml
@@ -539,7 +539,7 @@ modelBackend:
       maxUnavailable:
 # -- The configuration of artifact-backend
 artifactBackend:
-  # -- Enable artifact-backend deployment
+  # -- Enable artifact-backend deployment and milvus(and also minIO in milvus chart ) dependency
   enabled: true
   # -- The image of artifact-backend
   image:
@@ -1497,10 +1497,10 @@ milvus:
   log:
     level: "info"
     file:
-      maxSize: 10   # MB
-      maxAge: 12    # day
+      maxSize: 10 # MB
+      maxAge: 12 # day
       maxBackups: 2
-    format: "json"  # text/json
+    format: "json" # text/json
   cluster:
     enabled: true
   rootCoordinator: