Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(helm): add image-pull-secret tag for each service separately #1051

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(helm): add image-pull-secret tag for each service separately #1051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/core/templates/api-gateway/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ spec:
{{- end }}
automountServiceAccountToken: {{ .Values.console.automountServiceAccountToken | default false }}
terminationGracePeriodSeconds: 120
{{- with .Values.imagePullSecrets }}
{{- with .Values.apiGateway.imagePullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
{{- end }}
Expand Down
2 changes: 1 addition & 1 deletion charts/core/templates/artifact-backend/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ spec:
{{- end }}
automountServiceAccountToken: {{ .Values.artifactBackend.automountServiceAccountToken | default false }}
terminationGracePeriodSeconds: 120
{{- with .Values.imagePullSecrets }}
{{- with .Values.artifactBackend.imagePullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
{{- end }}
Expand Down
2 changes: 1 addition & 1 deletion charts/core/templates/mgmt-backend/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ spec:
{{- end }}
automountServiceAccountToken: {{ .Values.mgmtBackend.automountServiceAccountToken | default false }}
terminationGracePeriodSeconds: 120
{{- with .Values.imagePullSecrets }}
{{- with .Values.mgmtBackend.imagePullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
{{- end }}
Expand Down
8 changes: 4 additions & 4 deletions charts/core/templates/model-backend/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,13 @@ spec:
securityContext:
runAsUser: 65534
runAsGroup: 65534
{{- if .Values.modelBackend.serviceAccountName }}
serviceAccountName: {{ .Values.modelBackend.serviceAccountName }}
{{- end }}
{{- with .Values.imagePullSecrets }}
{{- with .Values.modelBackend.imagePullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- if .Values.modelBackend.serviceAccountName }}
serviceAccountName: {{ .Values.modelBackend.serviceAccountName }}
{{- end }}
automountServiceAccountToken: {{ .Values.modelBackend.automountServiceAccountToken | default false }}
terminationGracePeriodSeconds: 120
initContainers:
Expand Down
2 changes: 1 addition & 1 deletion charts/core/templates/model-backend/post-install-job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ spec:
{{- if .Values.modelBackend.serviceAccountName }}
serviceAccountName: {{ .Values.modelBackend.serviceAccountName }}
{{- end }}
{{- with .Values.imagePullSecrets }}
{{- with .Values.modelBackend.imagePullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
{{- end }}
Expand Down
2 changes: 1 addition & 1 deletion charts/core/templates/pipeline-backend/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ spec:
{{- end }}
automountServiceAccountToken: {{ .Values.pipelineBackend.automountServiceAccountToken | default false }}
terminationGracePeriodSeconds: 120
{{- with .Values.imagePullSecrets }}
{{- with .Values.pipelineBackend.imagePullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
{{- end }}
Expand Down
10 changes: 9 additions & 1 deletion charts/core/templates/ray-service/ray-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,11 @@ spec:
num-gpus: "0"
disable-usage-stats: "true"
template:
spec:
spec:
{{- with .Values.rayService.headGroupSpec.imagePullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 10 }}
{{- end }}
{{- with .Values.rayService.headGroupSpec.nodeSelector }}
nodeSelector:
{{- toYaml . | nindent 10 }}
Expand Down Expand Up @@ -131,6 +135,10 @@ spec:
# pod template
template:
spec:
{{- with $workerGroupSpecs.imagePullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 12 }}
{{- end }}
{{- with $workerGroupSpecs.nodeSelector }}
nodeSelector:
{{- toYaml . | nindent 12 }}
Expand Down
7 changes: 7 additions & 0 deletions charts/core/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,7 @@ usage:
port: 443
# -- The configuration of api-gateway
apiGateway:
imagePullSecrets:
# -- The image of api-gateway
image:
repository: instill/api-gateway
Expand Down Expand Up @@ -300,6 +301,7 @@ apiGateway:
maxUnavailable:
# -- The configuration of mgmt-backend
mgmtBackend:
imagePullSecrets:
# -- The image of mgmt-backend
image:
repository: instill/mgmt-backend
Expand Down Expand Up @@ -372,6 +374,7 @@ mgmtBackend:
serverName:
# -- The configuration of pipeline-backend
pipelineBackend:
imagePullSecrets:
# -- The image of pipeline-backend
image:
repository: instill/pipeline-backend
Expand Down Expand Up @@ -457,6 +460,7 @@ pipelineBackend:
modelBackendPortOverride:
# -- The configuration of model-backend
modelBackend:
imagePullSecrets:
# -- The image of model-backend
image:
repository: instill/model-backend
Expand Down Expand Up @@ -542,6 +546,7 @@ modelBackend:
artifactBackend:
# -- Enable artifact-backend deployment
enabled: true
imagePullSecrets:
# -- The image of artifact-backend
image:
repository: instill/artifact-backend
Expand Down Expand Up @@ -690,6 +695,7 @@ rayService:
tag: 0.4.0-alpha
pullPolicy: IfNotPresent
headGroupSpec:
imagePullSecrets:
resources:
limits:
cpu: "1"
Expand All @@ -706,6 +712,7 @@ rayService:
minReplicas: 1
maxReplicas: 1
groupName: "cpu-group"
imagePullSecrets:
gpuWorkerGroup:
enabled: false
# https://github.com/ray-project/ray/blob/master/python/ray/autoscaler/kuberay/ray-cluster.complete.yaml#L39
Expand Down
Loading