Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(pipeline): apply environment variables on migration command #1057

Merged
merged 1 commit into from
Aug 5, 2024
Merged

chore(pipeline): apply environment variables on migration command #1057

merged 1 commit into from
Aug 5, 2024

Conversation

jvallesm
Copy link
Collaborator

@jvallesm jvallesm commented Aug 5, 2024 •
edited
Loading

Because

  • We want to pass env variables to the migration command to perform extra migrations in cloud-only environments.

This commit

  • Reads the environment values defined in the Helm charts

@jvallesm jvallesm self-assigned this Aug 5, 2024
@linear Linear
Copy link

linear bot commented Aug 5, 2024

INS-5443 Store and index credit consumption per pipeline trigger and component

@jvallesm jvallesm marked this pull request as ready for review August 5, 2024 10:42
donch1989
donch1989 approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@donch1989 donch1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvallesm jvallesm merged commit 4bf5b61 into main Aug 5, 2024
35 of 37 checks passed
@jvallesm jvallesm deleted the jvalles/ins-5443-store-and-index-credit-consumption-per-pipeline-trigger-and branch August 5, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donch1989 donch1989 donch1989 approved these changes

@heiruwu heiruwu Awaiting requested review from heiruwu heiruwu is a code owner

@Sarthak-instill Sarthak-instill Awaiting requested review from Sarthak-instill Sarthak-instill is a code owner

Assignees

@jvallesm jvallesm

Labels
instill core
Projects
No open projects
🔮 Instill Core
Status: 👋 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jvallesm @donch1989 @droplet-bot