chore(vdp): update config #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuang8511
force-pushed
the
chunhao/update-config
branch
from
cf77854 to
620b7a4
Compare
donch1989
reviewed
Nov 19, 2024
charts/core/values.yaml
Outdated
| @@ -254,7 +254,7 @@ apiGateway: | |||
| additionalHosts: [] | |||
| # -- The TLS configuration for api-gateway | |||
| tls: | |||
| enabled: false | |||
| enabled: true | |||
There was a problem hiding this comment.
Don't change this. Let's keep the default be false here.
We'll override it in Terraform when deploying to cluster.
chore: update config chore: update config
chuang8511
force-pushed
the
chunhao/update-config
branch
from
620b7a4 to
df1149a
Compare
|
We can merge it. |
donch1989
requested review from
jvallesm,
heiruwu and
Sarthak-instill
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit