Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker-compose): fix EDITION var warnings #363

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

TobiaszCudnik
Copy link
Contributor

Because

  • warnings on make for EDITION

This commit

  • add a default value (empty string)
 !  ~/w/i/vdp   main …  make stop
WARN[0000] The "EDITION" variable is not set. Defaulting to a blank string. 
WARN[0000] The "EDITION" variable is not set. Defaulting to a blank string. 
WARN[0000] The "EDITION" variable is not set. Defaulting to a blank string. 
WARN[0000] The "EDITION" variable is not set. Defaulting to a blank string. 
[+] Stopping 5/5
 ✔ Container pipeline-backend-worker  Stopped                                                                                                                                                                                                                                                                                                                                                                                                                                              0.5s 
 ✔ Container connector-backend        Stopped                                                                                                                                                                                                                                                                                                                                                                                                                                              1.5s 
 ✔ Container controller-vdp           Stopped                                                                                                                                                                                                                                                                                                                                                                                                                                              0.5s 
 ✔ Container pipeline-backend         Stopped                                                                                                                                                                                                                                                                                                                                                                                                                                              2.6s 
 ✔ Container socat                    Stopped                                                                                                                                                                                                                                                                                                                                                                                                                                              0.4s 

Copy link
Member

@donch1989 donch1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donch1989 donch1989 changed the title chore: fix EDITION var warnings chore(docker-compose): fix EDITION var warnings Sep 26, 2023
@donch1989 donch1989 merged commit d3a52ac into main Sep 26, 2023
@donch1989 donch1989 deleted the chore/edition-var-warnings branch September 26, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants