Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(Makefile): fix make stop and start #365

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Conversation

pinglin
Copy link
Member

@pinglin pinglin commented Sep 26, 2023

Because

  • make stop/start was broken due to the containers used in docker compose depends_on that are removed after spin-up

This commit

  • remove docker compose rm -f in make all/latest
  • remove make rm and make restart (no use case)
  • revert EDITION setting logic

@pinglin pinglin force-pushed the pinglin/fix-make-stop-start branch from 4664426 to b2647a8 Compare September 26, 2023 23:07
@donch1989 donch1989 merged commit 04c9b9c into main Sep 27, 2023
@donch1989 donch1989 deleted the pinglin/fix-make-stop-start branch September 27, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants