Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs,tests): fix typo and grammar error #376

Merged
merged 7 commits into from
Oct 26, 2023
Merged

chore(docs,tests): fix typo and grammar error #376

merged 7 commits into from
Oct 26, 2023

Conversation

FarukhS52
Copy link
Contributor

@FarukhS52 FarukhS52 commented Oct 25, 2023 •
edited by donch1989
Loading

Because

  • there were so many typing errors and grammar errors in various files, so I tried and fix them

This commit

  • fixes almost all the typo and grammar errors in the repo

@FarukhS52 FarukhS52 changed the title Typo and grammar fix chore! : Typo and grammar fix Oct 25, 2023
@FarukhS52 FarukhS52 changed the title chore! : Typo and grammar fix chore : Typo and grammar fix Oct 25, 2023
@FarukhS52 FarukhS52 changed the title chore : Typo and grammar fix chore: Typo and grammar fix Oct 25, 2023
@donch1989
Copy link
Member

Hi @FarukhS52 ,
Thanks for your contribution. I'll make a small modification on your commit message title and merge it.

@donch1989 donch1989 changed the title chore: Typo and grammar fix chore: fix typo and grammar error Oct 26, 2023
@donch1989 donch1989 changed the title chore: fix typo and grammar error chore(docs,tests): fix typo and grammar error Oct 26, 2023
@FarukhS52
Copy link
Contributor Author

Thankyou @donch1989 for considering

@FarukhS52
Copy link
Contributor Author

@donch1989 is there any problem in this PR? Everytime its failing title check

@donch1989
Copy link
Member

@donch1989 is there any problem in this PR? Everytime its failing title check

Hi @FarukhS52,

The title test has passed.

The failing Make Latest test is due to your branch is not catch up with the latest main branch here. You need to rebase your branch to our latest commit

@FarukhS52
Copy link
Contributor Author

Ohhh, got it. Now all checks are passed,thanks @donch1989

@donch1989 donch1989 merged commit 39039a0 into instill-ai:main Oct 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donch1989 donch1989 donch1989 approved these changes

@heiruwu heiruwu Awaiting requested review from heiruwu heiruwu is a code owner

@Sarthak-instill Sarthak-instill Awaiting requested review from Sarthak-instill Sarthak-instill is a code owner

Assignees
No one assigned
Labels
None yet
Projects
No open projects
🔮 Instill Core
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FarukhS52 @donch1989 @droplet-bot