Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(Makefile): unify Instill Core instance host #399

Merged
merged 1 commit into from
Dec 7, 2023
Merged

ci(Makefile): unify Instill Core instance host #399

merged 1 commit into from
Dec 7, 2023

Conversation

pinglin
Copy link
Member

@pinglin pinglin commented Dec 7, 2023

Because

  • both env variables CONSOLE_URL_HOST and CONSOLE_PUBLIC_API_GATEWAY_HOST reflect to the Instill Core instance host, we can actually merge them into one INSTILL_CORE_HOST for the self-host users to deploy with custom hostname.

This commit

  • replace the env variables CONSOLE_URL_HOST and CONSOLE_PUBLIC_API_GATEWAY_HOST with INSTILL_CORE_HOST

@donch1989 donch1989 merged commit d3b33bf into main Dec 7, 2023
18 of 20 checks passed
@donch1989 donch1989 deleted the pinglin/ci-update-makefile branch December 7, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donch1989 donch1989 Awaiting requested review from donch1989 donch1989 is a code owner

@heiruwu heiruwu Awaiting requested review from heiruwu heiruwu is a code owner

@Sarthak-instill Sarthak-instill Awaiting requested review from Sarthak-instill Sarthak-instill is a code owner

Assignees
No one assigned
Labels
None yet
Projects
No open projects
🔮 Instill Core
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pinglin @donch1989 @droplet-bot