chore(helm): fix missing nvidia cdi spec for helm deployment #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heiruwu
requested review from
donch1989,
jvallesm and
Sarthak-instill
as code owners
donch1989
pushed a commit
that referenced
this pull request
Mar 20, 2024
Because - Helm deployment is missing nvidia CDI spec generation during ray-worker startup This commit - add `nvidia-ctk cdi generate` command in `postStart` hook - add `privileged` to ray-worker to avoid `newuidmap` operation not permitted error - set default registry forwarded port to `5001` to avoid conflicting with macOS ControlCenter Resolves INS-3955
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit
nvidia-ctk cdi generatecommand inpostStarthookprivilegedto ray-worker to avoidnewuidmapoperation not permitted error5001to avoid conflicting with macOS ControlCenterResolves INS-3955