Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): sync version to instill.tech website #968

Merged
merged 7 commits into from
May 20, 2024

Conversation

donch1989
Copy link
Member

Because

  • We want to sync the version to instill.tech website automatically.

This commit

  • Adds Github Action workflow for this.

Copy link
Member

@pinglin pinglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xiaofei-du xiaofei-du left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donch1989, I think the problem is more complicated.

See https://www.instill.tech/docs/core/deployment/docker-compose

CleanShot 2024-05-19 at 02 57 22

The version would be out of date in the documentation. I think maybe frontend team @iamnamananand996 can set a version variable that can by dynamically used in the mdx files to make sure all the version numbers are up-to-date.

@donch1989
Copy link
Member Author

@donch1989, I think the problem is more complicated.

See https://www.instill.tech/docs/core/deployment/docker-compose

CleanShot 2024-05-19 at 02 57 22

The version would be out of date in the documentation. I think maybe frontend team @iamnamananand996 can set a version variable that can by dynamically used in the mdx files to make sure all the version numbers are up-to-date.

Yes, we need to set a version variable in the instill.tech repo and using version.mjs as single source of truth

@iamnamananand996
Copy link

iamnamananand996 commented May 19, 2024

@donch1989, I think the problem is more complicated.

See https://www.instill.tech/docs/core/deployment/docker-compose

CleanShot 2024-05-19 at 02 57 22

The version would be out of date in the documentation. I think maybe frontend team @iamnamananand996 can set a version variable that can by dynamically used in the mdx files to make sure all the version numbers are up-to-date.

let me check, how we can set a version.mjs variable that can by dynamically used in the .mdx files.

@donch1989 donch1989 merged commit f3a3c43 into main May 20, 2024
35 checks passed
@donch1989 donch1989 deleted the huitang/sync-version branch May 20, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: 👋 Done
Development

Successfully merging this pull request may close these issues.

5 participants