Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(workflow): update github action default token #283

Conversation

Sarthak-instill
Copy link
Member

@Sarthak-instill Sarthak-instill commented Oct 26, 2023

Because

  • we need to update github action default token and remove docker hub login.

This commit

  • update github action default token

@linear
Copy link

linear bot commented Oct 26, 2023

INS-2412 For public repo's PR GA workflow, we don’t need to log in to our Docker Hub.

pinglin said:

engineering For our public repos’ pull request GA workflow, we don’t need to log in to our Docker Hub. The GA secret can’t be exposed to a forked repo anyway. Also, for Codecov GA workflow, we will need to use the GitHub default token here so the pull request from a forked repo branch can also trigger the Codecov GA workflow. sarthak.gupta Can you help update the logic for all repos. Thanks.

<https://github.com/instill-ai/model-backend/blob/main/.github/workflows/coverage.yml | coverage.yml>

@Sarthak-instill Sarthak-instill force-pushed the sarthakgupta/ins-2412-for-public-repos-pr-ga-workflow-we-dont-need-to-log-in-to branch from 9d9fc74 to bba8cce Compare October 26, 2023 10:27
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2bd5008) 0.00% compared to head (7e41a80) 0.00%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #283   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          7       7           
  Lines       2131    2131           
=====================================
  Misses      2131    2131           
Flag Coverage Δ
unittests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sarthak-instill Sarthak-instill force-pushed the sarthakgupta/ins-2412-for-public-repos-pr-ga-workflow-we-dont-need-to-log-in-to branch from bba8cce to 114cacb Compare October 26, 2023 10:39
@Sarthak-instill Sarthak-instill changed the title chore: add condition for docker hub login to fork PR ci(workflow): add condition for docker hub login to fork PR Oct 26, 2023
@Sarthak-instill Sarthak-instill force-pushed the sarthakgupta/ins-2412-for-public-repos-pr-ga-workflow-we-dont-need-to-log-in-to branch from 114cacb to ee419fb Compare October 26, 2023 19:38
@Sarthak-instill Sarthak-instill changed the title ci(workflow): add condition for docker hub login to fork PR ci(workflow): update github action default token Oct 26, 2023
@Sarthak-instill Sarthak-instill force-pushed the sarthakgupta/ins-2412-for-public-repos-pr-ga-workflow-we-dont-need-to-log-in-to branch from ee419fb to 7e41a80 Compare October 26, 2023 19:39
@donch1989 donch1989 merged commit 19aa1b9 into main Oct 27, 2023
11 checks passed
@donch1989 donch1989 deleted the sarthakgupta/ins-2412-for-public-repos-pr-ga-workflow-we-dont-need-to-log-in-to branch October 27, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants