Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pipeline): fix trigger error when start operator has field input #287

Conversation

donch1989
Copy link
Member

@donch1989 donch1989 commented Nov 5, 2023

Because

  • when we have input in start operator, the trigger will be error when set instill-return-traces=true

This commit

Copy link

linear bot commented Nov 5, 2023

INS-2514 [Bug] using `input` key in start operator will cause traces data error

Is There an Existing Issue for This?

  • I have searched the existing issues

Project

Instill VDP

Describe the Bug

  • using input key in start operator will cause trigger traces data error

Steps to Reproduce

  1. Create a field in start operator with key = "input"
  2. Trigger the pipeline with instill-return-traces = true

Actual Result

  • The trigger request return 400 error

Expected Behavior

  • The trigger request return 200 ok

Technical Details

  • Project version:
  • Service name:
  • Service version:
  • OS:
  • Browser:

Anything Else?

No response

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a9d5bd) 0.00% compared to head (82fb65b) 0.00%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    instill-ai/community#287   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          7       7           
  Lines       2131    2131           
=====================================
  Misses      2131    2131           
Flag Coverage Δ
unittests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@donch1989 donch1989 force-pushed the huitang/ins-2514-bug-using-input-key-in-start-operator-will-cause-traces-data branch from c8f64e9 to f981dcf Compare November 5, 2023 16:02
@donch1989 donch1989 force-pushed the huitang/ins-2514-bug-using-input-key-in-start-operator-will-cause-traces-data branch from f981dcf to ad27002 Compare November 5, 2023 16:04
@donch1989 donch1989 merged commit 9f7ae76 into main Nov 5, 2023
12 checks passed
@donch1989 donch1989 deleted the huitang/ins-2514-bug-using-input-key-in-start-operator-will-cause-traces-data branch November 5, 2023 16:21
donch1989 pushed a commit that referenced this pull request Nov 11, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.16.2-alpha](v0.16.1-alpha...v0.16.2-alpha)
(2023-11-11)


### Bug Fixes

* **pipeline:** fix trigger error when start operator has field `input`
([#287](#287))
([9f7ae76](9f7ae76))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[INS-2514] [Bug] using input key in start operator will cause traces data error
2 participants