Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schema package: Build a python package with the schema #27

Merged
merged 1 commit into from
Jun 17, 2024
Merged

schema package: Build a python package with the schema #27

merged 1 commit into from
Jun 17, 2024

Conversation

bjhargrave
Copy link
Contributor

This will allow schema users to pip install the schema instead of using something like git submodules to place the schema files at some local path.

@bjhargrave bjhargrave requested a review from tiran June 6, 2024 14:33
@bjhargrave
Copy link
Contributor Author

@tiran Can you review the changes here to build a python package for the schema? The goal is to replace using git submodules (as we currently do) with a python dependency.

@tiran
Copy link

tiran commented Jun 6, 2024

I'm happy to help. However I have very limited available until Jun 18th due to travel and other commitments.

@bjhargrave bjhargrave force-pushed the python-package branch 2 times, most recently from a6dd0d2 to bbc3d3d Compare June 6, 2024 19:51
This was referenced Jun 6, 2024
Merged
Merged
@bjhargrave bjhargrave force-pushed the python-package branch 20 times, most recently from 5dcb50f to 52d22f4 Compare June 10, 2024 19:59
@bjhargrave
Copy link
Contributor Author

@russellb @nathan-weinberg Can either of you look at this PR? I would like to get it in (we can always sort out any issues with PyPI packaging later; the publish steps are "falsed" out now). Then other projects like the cli and taxonomy can move to use the package via a pip git+ url to this repo.

I have PRs in cli (instructlab/instructlab#1285) and taxonomy (instructlab/taxonomy#1169), to demonstrate accessing the schema via an installed package is working.

@bjhargrave
Copy link
Contributor Author

I created a pending publisher for instructlab-schema as documented in https://docs.pypi.org/trusted-publishers/creating-a-project-through-oidc/.

@bjhargrave bjhargrave force-pushed the python-package branch 2 times, most recently from 466f678 to d69176d Compare June 14, 2024 17:53
@bjhargrave bjhargrave requested a review from leseb June 14, 2024 18:03
@bjhargrave
schema package: Build a python package for the schema
72f5382 
This will allow schema users to pip install the schema instead of
using something like git submodules to place the schema files at some
local path.

Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
@bjhargrave bjhargrave merged commit eed26b3 into instructlab:main Jun 17, 2024
15 checks passed
@bjhargrave bjhargrave deleted the python-package branch June 17, 2024 20:47
@bjhargrave bjhargrave restored the python-package branch June 17, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathan-weinberg nathan-weinberg nathan-weinberg approved these changes

@tiran tiran Awaiting requested review from tiran

@russellb russellb Awaiting requested review from russellb

@leseb leseb Awaiting requested review from leseb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjhargrave @tiran @nathan-weinberg