-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Taxonomy reading API #33
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjhargrave
force-pushed
the
taxonomy-reading
branch
13 times, most recently
from
July 1, 2024 20:49
4eafaac
to
bbf2c7a
Compare
bjhargrave
added a commit
to bjhargrave/instructlab_sdg
that referenced
this pull request
Jul 1, 2024
We remove code duplicated with instructlab to use the shared code from instructlab-schema package. See instructlab/schema#33 Signed-off-by: BJ Hargrave <bj@hargrave.dev>
bjhargrave
force-pushed
the
taxonomy-reading
branch
5 times, most recently
from
July 3, 2024 13:09
e860d61
to
7b84b29
Compare
bjhargrave
force-pushed
the
taxonomy-reading
branch
9 times, most recently
from
July 7, 2024 10:41
ac285f1
to
603e02f
Compare
bjhargrave
force-pushed
the
taxonomy-reading
branch
from
July 8, 2024 22:10
603e02f
to
5e872ea
Compare
bjhargrave
force-pushed
the
taxonomy-reading
branch
2 times, most recently
from
July 12, 2024 16:54
154d2a5
to
0e1d7ff
Compare
bjhargrave
force-pushed
the
taxonomy-reading
branch
3 times, most recently
from
July 17, 2024 13:11
e920c11
to
c8c9795
Compare
This was referenced Jul 17, 2024
bjhargrave
force-pushed
the
taxonomy-reading
branch
from
July 23, 2024 17:31
c8c9795
to
4a12d7a
Compare
nathan-weinberg
approved these changes
Jul 29, 2024
Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
bjhargrave
force-pushed
the
taxonomy-reading
branch
from
July 29, 2024 20:03
4a12d7a
to
3bb136e
Compare
The description is also updated to direct users to v3. Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
bjhargrave
force-pushed
the
taxonomy-reading
branch
from
July 30, 2024 16:08
3bb136e
to
3fcb971
Compare
The parse method will yamllint and jsonschema validate a qna.yaml file. It will return an object holding the parsed yaml. Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
bjhargrave
force-pushed
the
taxonomy-reading
branch
from
July 30, 2024 17:55
3fcb971
to
b903539
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a central API for parsing and validating taxonomy qna.yaml files.