offshoot gen_test_data() from very long generate_data() #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for posting the PR to this repo! The changes look good, though it would make my life a little easier if I hold off on merging it until I can remove the original code from |
russellb
requested changes
Jun 24, 2024
|
Thanks for the updates. The changes look good, though it's highlighting the lack of integration testing in this repo. I'm going to look into that now. |
|
I got an e2e workflow enabled on this repo in #33. I'm going to rebase this PR to trigger it to run. |
|
@Mergifyio rebase |
Function generate_data() is huge and messy. Refactor it. Move code around `json.dump` to gen_test_data() because it is under loop `for instruction_data_entry in instruction_data` by accidentally. Code is just moved, without internal changes. Signed-off-by: Costa Shulyupin <costa.shul@redhat.com>
Function generate_data() is huge and messy. Refactor it. Signed-off-by: Costa Shulyupin <costa.shul@redhat.com>
✅ Branch has been successfully rebased |
russellb
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function generate_data is huge and messy.
Refactor it.