Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use schema python package #1169

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

bjhargrave
Copy link
Contributor

Update check_yaml to use instructlab-schema package instead of git submodule.

@github-actions github-actions bot added the ci label Jun 6, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 6, 2024
@bjhargrave bjhargrave force-pushed the schema-python-package branch 2 times, most recently from 918ffe8 to ffd9482 Compare June 6, 2024 18:23
@bjhargrave
Copy link
Contributor Author

See instructlab/schema#27 for the creation of the Python package for the schema.

@bjhargrave bjhargrave force-pushed the schema-python-package branch 3 times, most recently from 6248145 to 88a95e2 Compare June 7, 2024 20:41
@bjhargrave
Copy link
Contributor Author

@Mergifyio rebase

Copy link

mergify bot commented Jun 10, 2024

rebase

✅ Branch has been successfully rebased

Placing the scripts in .github was a historical accident.

Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
Copy link
Member

@jjasghar jjasghar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay no submodules!!!

@bjhargrave bjhargrave merged commit dee9c9f into instructlab:main Jun 20, 2024
7 checks passed
@bjhargrave bjhargrave deleted the schema-python-package branch June 20, 2024 21:00
ljmwaugh pushed a commit to ljmwaugh/taxonomy that referenced this pull request Jun 26, 2024
Update check_yaml to use instructlab-schema package instead of git
submodule.

---------

Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants