Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-17947][Parent] Fixed student colors and theme colors #2579

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

tamaskozmer
Copy link
Contributor

@tamaskozmer tamaskozmer commented Oct 3, 2024

Test plan: Test that the app is accessible in both dark mode and light mode. Some notes:

  • I fixed the student colors so they have different shade in dark/light mode.
  • Fixed canvas brand colors and theme/student color switching.
  • Same things apply as for the other apps, when we have a colored background it should have dark text in dark mode, light in light mode and it should be clearly visible.
  • I made some refactoring and corrected some other color issues throughout the Parent app.

refs: MBL-17947
affects: Parent
release note: none

Screenshots

Checklist

  • Tested in dark mode
  • Tested in light mode
  • A11y checked

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Parent Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Parent Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Parent Install Page

# Conflicts:
#	apps/parent/src/main/java/com/instructure/parentapp/features/addstudent/AddStudentViewModel.kt
#	apps/parent/src/main/java/com/instructure/parentapp/features/alerts/list/AlertsViewModel.kt
#	apps/parent/src/main/java/com/instructure/parentapp/features/calendar/ParentCalendarFragment.kt
#	apps/parent/src/main/java/com/instructure/parentapp/features/courses/list/CoursesViewModel.kt
#	apps/parent/src/main/java/com/instructure/parentapp/features/dashboard/DashboardFragment.kt
#	apps/parent/src/main/java/com/instructure/parentapp/features/dashboard/DashboardViewModel.kt
#	apps/parent/src/test/java/com/instructure/parentapp/features/alerts/list/AlertsViewModelTest.kt
#	apps/parent/src/test/java/com/instructure/parentapp/features/courses/list/CoursesViewModelTest.kt
#	apps/parent/src/test/java/com/instructure/parentapp/features/dashboard/DashboardViewModelTest.kt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants