Optimize bitrise #3051

vargaat · 2025-01-06T15:00:31Z

What's new?

A brand new bitrise app created with the yml file hosted in our repository.
Workflow for PR ad-hoc builds supporting all 4 apps.
A single workflow to trigger and build all apps to reduce build count from 5 (trigger + 3 canvas apps + horizon) to 1.
In case when the 3 canvas apps are built the total build time is reduced from 24 minutes to 18 m 30 sec, if we include horizon the save is even larger.

Bitrise Configurations:

.bitrise/bitrise.yml: The root Bitrise yml file with common workflows for preparing the workspace and saving SPM cache. This includes the adhoc yml file.
.bitrise/pr_adhoc/bitrise_pr_adhoc.yml: Ad-hoc specific workflows.

Script Additions:

.bitrise/pr_adhoc/create_pr_comment.sh: Script to generate a PR comment with QR codes for each app build.
.bitrise/pr_adhoc/discover_apps_to_build.sh: Script to discover which apps need to be built based on the pull request's description.
.bitrise/pr_adhoc/write_qr_url_to_file.sh: Helper script to write the QR code URL to a file for each app so it can be read by other workflows/steps.

refs: MBL-18174
affects: Student, Teacher, Parent

… the Horizon app.

…es to a dedicated folder.

…tag updating.

[ignore-commit-lint]

inst-danger · 2025-01-06T15:07:59Z

Teacher Build QR Code:

inst-danger · 2025-01-06T15:18:46Z

Builds

Student	Teacher	Parent

inst-danger · 2025-01-06T15:37:19Z

Parent Build QR Code:

inst-danger · 2025-01-06T15:39:39Z

Student Build QR Code:

inst-danger · 2025-01-06T15:45:23Z

	Fails
🚫	Build failed, skipping coverage check

❌ XCTest failed: CoreTests/AssignmentCellViewModelTests/testSubmissionStatusAndIconAndColor

XCTAssertEqual failed: ("#6a7883") is not equal to ("#697783")
XCTAssertEqual failed: ("#03893d") is not equal to ("#03893c")

❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testAutomaticRead

Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x113012800; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002366f80; name = backgroundLightest>; layer = <CALayer: 0x6000006eb7e0>>".
XCTAssertNotNil failed
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x113012800; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002366f80; name = backgroundLightest>; layer = <CALayer: 0x6000006eb7e0>>".
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x113012800; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002366f80; name = backgroundLightest>; layer = <CALayer: 0x6000006eb7e0>>".

❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testLayout

Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x108068000; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002366f80; name = backgroundLightest>; layer = <CALayer: 0x60000072d980>>".
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x108068000; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002366f80; name = backgroundLightest>; layer = <CALayer: 0x60000072d980>>".
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x108068000; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002366f80; name = backgroundLightest>; layer = <CALayer: 0x60000072d980>>".
XCTAssertTrue failed
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x108068000; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002366f80; name = backgroundLightest>; layer = <CALayer: 0x60000072d980>>".
XCTAssertTrue failed

❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testShowEntry

Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x111008200; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002366f80; name = backgroundLightest>; layer = <CALayer: 0x600000711e40>>".
XCTAssertEqual failed: ("nil") is not equal to ("Optional("4")")

❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testShowReplies

Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x106018600; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002366f80; name = backgroundLightest>; layer = <CALayer: 0x60000071a140>>".
XCTAssertTrue failed
XCTAssertTrue failed

❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testStudentGroupTopic

Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x10802be00; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002366f80; name = backgroundLightest>; layer = <CALayer: 0x60000072eb40>>".
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed

❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testStudentGroupTopicWhenUserNotInAGroup

Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x108076600; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002366f80; name = backgroundLightest>; layer = <CALayer: 0x60000072f3c0>>".
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed

❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testTeacherGroupTopic

Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x10807b200; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002366f80; name = backgroundLightest>; layer = <CALayer: 0x60000072fc40>>".
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed

Generated by 🚫 dangerJS against 60b0868

.bitrise/pr_adhoc/bitrise_pr_adhoc.yml

.bitrise/pr_adhoc/create_pr_comment.sh

rh12

Thanks for consolidating all this!

ndrsszsz

Nice! 👍

…plit adhoc yml into two separate ones.

szabinst

Nice improvements! 🚀

Deluciferrral · 2025-01-12T14:01:49Z

No1

vargaat added 30 commits December 12, 2024 11:03

Add empty yml.

898ebd0

Add common workflows and a dedicated yml for adhoc builds.

465017d

Remove include.

0518271

Remove adhoc workflows, re-add include.

cb0b901

Add empty workflow to adhoc yml.

583d46e

Add discovery workflow.

70bcc23

Add adhoc utility step.

af1c60f

Remove unnecessary trigger.

083b143

Rename adhoc yml.

ca157c8

Add build triggers to each app.

9b83dd3

Move comment to main workflow.

cefe818

Extract QR code based on the built scheme.

a18f195

Fix QR key. Add unified QR code table as comment.

59f4cf4

Fix variable name. Omit clean operation before builds.

9008448

Add back updated PR comment step.

3ea1e7e

Add PR trigger.

1c3a2cd

Don't run PR comment step if workflow failed.

11b4808

Add human readable status report name.

3c32627

Don't use utility workflow format for adhoc build.

62affbe

Reference the outer yml when starting sub-build.

312d28b

Update build number update step to its latest version.

bf85b12

Extract app icon location to an external variable since it differs in…

8cab76a

… the Horizon app.

Enable verbose loggin for xcode build.

841b12c

Extract PR comment script to a dedicated file. Move adhoc related fil…

2267677

…es to a dedicated folder.

Write QR urls to file from child workflow.

8d1e11a

Change img tag src to double quotes. Crank up compression on SPM cache.

28a1b41

Fix variable not being quoted during envman export. Turn off comment …

b9fb70d

…tag updating.

Minor updates, restore PR comment updating.

4c14863

[ignore-commit-lint]

Switch to the fastest compression on SPM cache.

3f204da

Update script headers.

33f94ae

vargaat added 6 commits January 2, 2025 12:13

Bump bitrise to Xcode 16.2.

7e03c33

Merge branch 'master' into chore/MBL-18174-optimize-bitrise

ec72ae9

Update CSS.

69f50ba

Extract app discovery shell script from yml file.

cf63560

Remove custom CSS since they don't work in github comments.

98fcd16

Unify tabs to 4 spaces in shell scripts.

9162965

vargaat requested review from szabinst, rh12, ndrsszsz and suhaibabsi-inst as code owners January 6, 2025 15:00

vargaat self-assigned this Jan 6, 2025

rh12 reviewed Jan 6, 2025

View reviewed changes

.bitrise/pr_adhoc/bitrise_pr_adhoc.yml Outdated Show resolved Hide resolved

.bitrise/pr_adhoc/create_pr_comment.sh Outdated Show resolved Hide resolved

.bitrise/pr_adhoc/create_pr_comment.sh Show resolved Hide resolved

Update workflow comment. Make details tag open by default.

1166254

rh12 previously approved these changes Jan 7, 2025

View reviewed changes

ndrsszsz previously approved these changes Jan 7, 2025

View reviewed changes

Remove unnecessary environment settings from time zone update step. S…

60b0868

…plit adhoc yml into two separate ones.

vargaat dismissed stale reviews from ndrsszsz and rh12 via 60b0868 January 8, 2025 15:25

szabinst approved these changes Jan 8, 2025

View reviewed changes

vargaat requested review from ndrsszsz and rh12 January 9, 2025 07:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optimize bitrise #3051

Optimize bitrise #3051

vargaat commented Jan 6, 2025 •

edited by jira bot

Loading

inst-danger commented Jan 6, 2025 •

edited

Loading

inst-danger commented Jan 6, 2025 •

edited

Loading

inst-danger commented Jan 6, 2025 •

edited

Loading

inst-danger commented Jan 6, 2025 •

edited

Loading

inst-danger commented Jan 6, 2025 •

edited

Loading

rh12 left a comment

ndrsszsz left a comment

szabinst left a comment

Deluciferrral commented Jan 12, 2025

Optimize bitrise #3051

Are you sure you want to change the base?

Optimize bitrise #3051

Conversation

vargaat commented Jan 6, 2025 • edited by jira bot Loading

What's new?

Bitrise Configurations:

Script Additions:

inst-danger commented Jan 6, 2025 • edited Loading

inst-danger commented Jan 6, 2025 • edited Loading

Builds

inst-danger commented Jan 6, 2025 • edited Loading

inst-danger commented Jan 6, 2025 • edited Loading

inst-danger commented Jan 6, 2025 • edited Loading

rh12 left a comment

Choose a reason for hiding this comment

ndrsszsz left a comment

Choose a reason for hiding this comment

szabinst left a comment

Choose a reason for hiding this comment

Deluciferrral commented Jan 12, 2025

vargaat commented Jan 6, 2025 •

edited by jira bot

Loading

inst-danger commented Jan 6, 2025 •

edited

Loading

inst-danger commented Jan 6, 2025 •

edited

Loading

inst-danger commented Jan 6, 2025 •

edited

Loading

inst-danger commented Jan 6, 2025 •

edited

Loading

inst-danger commented Jan 6, 2025 •

edited

Loading