-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility - Teacher - Calendar - Font size on Edit Event screen #3061
Open
ndrsszsz
wants to merge
2
commits into
master
Choose a base branch
from
bugfix/MBL-18306-a11y-teacher-calendar-event-font-size
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Accessibility - Teacher - Calendar - Font size on Edit Event screen #3061
ndrsszsz
wants to merge
2
commits into
master
from
bugfix/MBL-18306-a11y-teacher-calendar-event-font-size
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affects: Student, Teacher release note: None test plan: No text should get cut off on EditCalendarEventScreen when font size is increased to the maximum.
ndrsszsz
requested review from
vargaat,
szabinst,
rh12 and
suhaibabsi-inst
as code owners
January 14, 2025 11:43
Affected Apps: Student, Teacher❌ XCTest failed: CoreTests/LoginStartViewControllerTests/testAnimateIn
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code +1
suhaibabsi-inst
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA +1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
affects: Student, Teacher
release note: None
test plan: No text should get cut off on EditCalendarEventScreen when font size is increased to the maximum.
I'm not quite pleased with the solution so any suggestion is appreciated.
Before:
Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2025-01-14.at.12.42.53.mp4
After:
Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2025-01-14.at.12.39.56.mp4
Checklist