Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility - Teacher - Calendar - Font size on Edit Event screen #3061

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ndrsszsz
Copy link
Contributor

affects: Student, Teacher
release note: None
test plan: No text should get cut off on EditCalendarEventScreen when font size is increased to the maximum.

I'm not quite pleased with the solution so any suggestion is appreciated.

Before:

Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2025-01-14.at.12.42.53.mp4

After:

Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2025-01-14.at.12.39.56.mp4

Checklist

  • Follow-up e2e test ticket created
  • A11y checked
  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode
  • Approve from product

affects: Student, Teacher
release note: None
test plan: No text should get cut off on EditCalendarEventScreen when font size is increased to the maximum.
@inst-danger
Copy link
Contributor

inst-danger commented Jan 14, 2025

Teacher Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Jan 14, 2025

Student Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Jan 14, 2025

Fails
🚫 Build failed, skipping coverage check
Warnings
⚠️ This pull request will not generate a release note.

Affected Apps: Student, Teacher

MBL-18306

❌ XCTest failed: CoreTests/LoginStartViewControllerTests/testAnimateIn
XCTAssertEqual failed: ("1.0") is not equal to ("0.0")

Generated by 🚫 dangerJS against b0cff13

Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code +1

Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants