-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Horizon] Highlighting and Annotating Text #3072
Open
reabbotted
wants to merge
38
commits into
feature/horizon
Choose a base branch
from
feature/CLX-163-i-os-add-note-view
base: feature/horizon
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the access levels for some of the items so they can be used in the project
…erences to other values
…ButtonStyles to helper functions for readability
reabbotted
requested review from
ktheory,
JacksonHowe and
Ahmed-Naguib93
as code owners
January 16, 2025 18:39
❌ XCTest failed: CoreTests/AssignmentCellViewModelTests/testSubmissionStatusAndIconAndColor
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testAutomaticRead
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testLayout
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testShowEntry
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testShowReplies
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testStudentGroupTopic
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testStudentGroupTopicWhenUserNotInAGroup
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testTeacherGroupTopic
|
reabbotted
commented
Jan 16, 2025
packages/HorizonUI/Sources/HorizonUI/Sources/Foundation/Fonts/HorizonUI.Fonts.swift
Show resolved
Hide resolved
…eightMultiple to match what swiftui does
… we can display the highlighted text when showing the note
…yed and removing my demo paragraphs
balintbartok
changed the title
Highlighting and Annotating Text
[Horizon] Highlighting and Annotating Text
Jan 21, 2025
… text in the NotebookCourseListView
Ahmed-Naguib93
previously approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the NoteableTextView. This is a custom TextView for allowing highlighting text for annotation. It presents a custom set of buttons when the user highlights text. They can mark the text important or confusing and it will highlight the text in the appropriate color. They may also highlight the text and add a note. This will bring up the view for adding a note and highlight the text in yellow. They may also tap on text previously highlighted and it will bring up the view for viewing the note.