Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Horizon] Highlighting and Annotating Text #3072

Open
wants to merge 38 commits into
base: feature/horizon
Choose a base branch
from

Conversation

reabbotted
Copy link

@reabbotted reabbotted commented Jan 16, 2025

Adding the NoteableTextView. This is a custom TextView for allowing highlighting text for annotation. It presents a custom set of buttons when the user highlights text. They can mark the text important or confusing and it will highlight the text in the appropriate color. They may also highlight the text and add a note. This will bring up the view for adding a note and highlight the text in yellow. They may also tap on text previously highlighted and it will bring up the view for viewing the note.

Updating the access levels for some of the items so they can be used in the project
…ButtonStyles to helper functions for readability
@reabbotted reabbotted requested a review from szabinst as a code owner January 16, 2025 18:39
@inst-danger
Copy link
Contributor

inst-danger commented Jan 16, 2025

Fails
🚫

Please add a release note. If no release note is wanted, use none. Example: release note: Fixed a bug that prevented users from enjoying the app.

🚫

Please add which apps this change affects. Example: affects: Teacher, Student or affects: none

🚫

Please add a reference to a Jira ticket. For example: refs: MBL-10023

🚫 Build failed, skipping coverage check
🚫

Please run yarn update-headers. The following do not have the correct license header:

  • Horizon/Horizon/Sources/Features/Notebook/Common/View/NoteableTextView/NoteableTextView.swift
❌ XCTest failed: CoreTests/AssignmentCellViewModelTests/testSubmissionStatusAndIconAndColor
XCTAssertEqual failed: ("#6a7883") is not equal to ("#697783")
XCTAssertEqual failed: ("#03893d") is not equal to ("#03893c")
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testAutomaticRead
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x105036800; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002380320; name = backgroundLightest>; layer = <CALayer: 0x600000711fa0>>".
XCTAssertNotNil failed
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x105036800; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002380320; name = backgroundLightest>; layer = <CALayer: 0x600000711fa0>>".
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x105036800; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002380320; name = backgroundLightest>; layer = <CALayer: 0x600000711fa0>>".
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testLayout
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x106833400; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002380320; name = backgroundLightest>; layer = <CALayer: 0x6000007296c0>>".
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x106833400; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002380320; name = backgroundLightest>; layer = <CALayer: 0x6000007296c0>>".
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x106833400; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002380320; name = backgroundLightest>; layer = <CALayer: 0x6000007296c0>>".
XCTAssertTrue failed
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x106833400; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002380320; name = backgroundLightest>; layer = <CALayer: 0x6000007296c0>>".
XCTAssertTrue failed
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testShowEntry
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x107038600; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002380320; name = backgroundLightest>; layer = <CALayer: 0x6000006fda40>>".
XCTAssertEqual failed: ("nil") is not equal to ("Optional("4")")
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testShowReplies
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x10702fe00; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002380320; name = backgroundLightest>; layer = <CALayer: 0x6000006fe2c0>>".
XCTAssertTrue failed
XCTAssertTrue failed
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testStudentGroupTopic
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x107043000; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002380320; name = backgroundLightest>; layer = <CALayer: 0x6000006feb40>>".
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testStudentGroupTopicWhenUserNotInAGroup
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x107045c00; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002380320; name = backgroundLightest>; layer = <CALayer: 0x6000006ff3c0>>".
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testTeacherGroupTopic
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x10704a400; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002380320; name = backgroundLightest>; layer = <CALayer: 0x6000006ffc40>>".
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed

Generated by 🚫 dangerJS against 9aee47d

@balintbartok balintbartok changed the title Highlighting and Annotating Text [Horizon] Highlighting and Annotating Text Jan 21, 2025
@inst-danger
Copy link
Contributor

inst-danger commented Jan 21, 2025

Horizon Build QR Code:

Ahmed-Naguib93
Ahmed-Naguib93 previously approved these changes Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants