-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Horizon] Module Sequence View #3076
base: feature/horizon
Are you sure you want to change the base?
[Horizon] Module Sequence View #3076
Conversation
❌ XCTest failed: CoreTests/AssignmentCellViewModelTests/testSubmissionStatusAndIconAndColor
❌ XCTest failed: CoreTests/CoreSearchHostingControllerTests/test_search_experience_started
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testAutomaticRead
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testLayout
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testShowEntry
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testShowReplies
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testStudentGroupTopic
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testStudentGroupTopicWhenUserNotInAGroup
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testTeacherGroupTopic
|
Horizon/Horizon/Sources/Features/ModuleItemSequence/Domain/ModuleItemSequenceInteractor.swift
Outdated
Show resolved
Hide resolved
I worry about how deeply rooted the AppEnvironment is passed through the classes. That makes all of those classes dependent on that AppEnvironment class. It would be best to limit those classes to only require just what they need to get their job done to make them more reusable. |
Horizon/Horizon/Sources/Features/ModuleItemSequence/ModuleNavBar/View/ModuleNavBarView.swift
Outdated
Show resolved
Hide resolved
Horizon/Horizon/Sources/Features/ModuleItemSequence/View/ModuleItemSequenceView.swift
Show resolved
Hide resolved
Horizon/Horizon/Sources/Features/ModuleItemSequence/View/ModuleItemSequenceView.swift
Show resolved
Hide resolved
It works well. My general comments are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for tackling this, this has been a pain point for a long time! Generally, it works well and the logic is well abstracted too.
I'd like to see some file reorganization inside the ModuleItemSequence
folder.
- The assembly file could live in the root like how other features are set up
- The
ModuleNavBar
folder should directly contain those two files, and theModuleNavBar
folder itself could go underModuleItemSequence/View/ModuleNavBar
- Same is true for
RepresentableViews
folder
https://instructure.atlassian.net/browse/CLX-342
Module Sequence View