-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect to AI Service #3077
base: feature/horizon
Are you sure you want to change the base?
Connect to AI Service #3077
Conversation
❌ XCTest failed: CoreTests/AssignmentCellViewModelTests/testSubmissionStatusAndIconAndColor
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testAutomaticRead
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testLayout
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testShowEntry
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testShowReplies
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testStudentGroupTopic
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testStudentGroupTopicWhenUserNotInAGroup
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testTeacherGroupTopic
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, we should try to follow our existing patterns and
- use Combine instead of async-await (however in the long run we should definitely evaluate it with the whole iOS team with a proper RfC)
- use the existing API structure with
API
,APIRequestable
- use the existing graphQL structure
APIGraphQLRequestable
You can check:
GetCoursesProgressionRequest
to see how a graphQL request is structuredStudioAPIAuthInteractor
to get an idea how you could interact with an API that is not canvas
Testing:
- If we stick to Combine, we can leverage
combine-schedulers
and test async behaviour like it was synchronous. CheckCalendarFilterInteractorTests L102
and other places wherescheduler: .immediate
is used.
New target, new dependencies:
- Any new target, dependency needs to be added to the project's yml file, in this case
/canvas-ios/Horizon/project.yml
andproject-ci.yml
so XcodeGen can generate the project file correctly.
To test this, just tap the AI button on the home screen and type in a message.