Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix e2e sfu tests #127

Merged
merged 75 commits into from
Nov 29, 2023
Merged

Fix e2e sfu tests #127

merged 75 commits into from
Nov 29, 2023

Conversation

rogurotus
Copy link
Contributor

@rogurotus rogurotus commented Aug 14, 2023 •
edited by tyranron
Loading

Synopsis

Some tests fail in SFU mode.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@rogurotus rogurotus self-assigned this Aug 14, 2023
@rogurotus rogurotus added enhancement Improvement of existing features or bugfix k::testing Related to testing and/or automated tests labels Aug 14, 2023
@rogurotus rogurotus force-pushed the fix-sfu-connection-loss-test branch from 28d08e3 to 3316ae4 Compare October 26, 2023 12:58
@alexlapa alexlapa requested a review from tyranron November 29, 2023 09:27
@tyranron tyranron added k::toolchain Related to project toolchain k::dependencies Pull requests that update a dependency file k::refactor Refactoring, technical debt elimination and other improvements of existing code base labels Nov 29, 2023
@tyranron tyranron merged commit 116a5fb into master Nov 29, 2023
52 checks passed
@tyranron tyranron deleted the fix-sfu-connection-loss-test branch November 29, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexlapa alexlapa alexlapa approved these changes

@tyranron tyranron tyranron approved these changes

Assignees

@rogurotus rogurotus

Labels
enhancement Improvement of existing features or bugfix k::dependencies Pull requests that update a dependency file k::refactor Refactoring, technical debt elimination and other improvements of existing code base k::testing Related to testing and/or automated tests k::toolchain Related to project toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rogurotus @tyranron @alexlapa @logist322