Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor static mut usage in medea-macro #196

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Dec 19, 2024

Related to #193

Synopsis

We need to refactor static mut usage from the medea-macro crate.

After this PR we will get rid of all static mut usage in medea-jason crate.

Solution

Replace all static mut inside #[dart_bridge] macro with thread_local! based alternatives.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
    • Has assignee
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@evdokimovs evdokimovs self-assigned this Dec 19, 2024
@evdokimovs evdokimovs added enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base k::security Related to security labels Dec 19, 2024
@evdokimovs
Copy link
Contributor Author

FCM

Refactor `static mut` usage in `medea-macro` (#196)

Additionally:
- fix unused import related to feature gated Android logger
- temporary disable `wasm-opt`

@evdokimovs evdokimovs marked this pull request as ready for review December 25, 2024 15:57
@evdokimovs evdokimovs requested a review from alexlapa December 25, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base k::security Related to security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant