Merge pull request #907 from intechstudio/feat/Analytics

Fixed analytics bombardment on update action
intechstudio · Jan 20, 2025 · c3b8168 · c3b8168
2 parents 2c7451d + 4dcb8a0
commit c3b8168
Showing 1 changed file with 18 additions and 19 deletions.
diff --git a/src/renderer/runtime/operations.ts b/src/renderer/runtime/operations.ts
@@ -188,35 +188,34 @@ export async function clearElement(target: GridElement) {
 }
 
 export async function syncWithGrid(target: GridAction) {
-  target.sendToGrid();
+  target.sendToGrid().finally(() => {
+    const event = target.parent as GridEvent;
+    const element = event.parent as GridElement;
+    Analytics.track({
+      event: "Config Action",
+      payload: {
+        click: "Update",
+        elementType: element.type,
+        eventType: event.type,
+        short: target.short,
+      },
+      mandatory: false,
+    });
+  });
 }
 
 export async function updateAction(
   target: GridAction,
   data: ActionData,
-  syncWithGrid: boolean
+  sync: boolean
 ) {
   target
     .updateData(data)
-    .then((result) => {
-      if (syncWithGrid) {
-        target.sendToGrid();
-      }
-    })
     .catch(handleError)
     .finally(() => {
-      const event = target.parent as GridEvent;
-      const element = event.parent as GridElement;
-      Analytics.track({
-        event: "Config Action",
-        payload: {
-          click: "Update",
-          elementType: element.type,
-          eventType: event.type,
-          short: target.short,
-        },
-        mandatory: false,
-      });
+      if (sync) {
+        syncWithGrid(target);
+      }
     });
 }