Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PP inference for chatglm3 #11375

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Support PP inference for chatglm3 #11375

merged 3 commits into from
Jun 21, 2024

Conversation

plusbang
Copy link
Contributor

@plusbang plusbang commented Jun 20, 2024 •
edited
Loading

Description

Support chatglm3 and update related PP example

2. User API changes

N/A

3. Summary of the change

  • Add split operations for chatglm model structure
  • Add num_layers config and other compatible processing
  • Add related example script

4. How to test?

  • Unit test
  • Local test
    image

sgwhat
sgwhat reviewed Jun 20, 2024
View reviewed changes
Copy link
Contributor

@sgwhat sgwhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can use try/except instead of creating a new glm_generate.py.

@plusbang
Copy link
Contributor Author

Maybe we can use try/except instead of creating a new glm_generate.py.

Have updated.

@plusbang plusbang requested a review from sgwhat June 20, 2024 08:12
sgwhat
sgwhat approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@sgwhat sgwhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plusbang plusbang merged commit 4ba8219 into intel-analytics:main Jun 21, 2024
31 checks passed
RyuKosei pushed a commit to RyuKosei/ipex-llm that referenced this pull request Jul 19, 2024
@plusbang @MeouSker77
Support PP inference for chatglm3 (intel-analytics#11375)
a392d9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgwhat sgwhat sgwhat approved these changes

@qiuxin2012 qiuxin2012 Awaiting requested review from qiuxin2012

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plusbang @sgwhat