add npu_group_size for transformers_int4_npu_win in all-in-one benchmark api
#12316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
small bugfix
rnwang04
reviewed
Nov 1, 2024
| @@ -2193,6 +2198,8 @@ def run_pipeline_parallel_gpu(repo_id, | |||
| optimize_model = conf['optimize_model'] | |||
| if 'group_size' in conf: | |||
| group_size = conf['group_size'] | |||
rnwang04
changed the title
npu_group_size for transformers_int4_npu_winnpu_group_size for transformers_int4_npu_win in all-in-one benchmark api
cyita
approved these changes
Nov 1, 2024
| @@ -214,7 +214,8 @@ def run_model(repo_id, test_api, in_out_pairs, local_model_hub=None, warm_up=1, | |||
| round(result[in_out_pair][-1][5], 2), | |||
| result[in_out_pair][-1][6] if any(keyword in test_api for keyword in ['int4_gpu', 'int4_fp16_gpu_win', 'int4_loadlowbit_gpu', 'int4_fp16_loadlowbit_gpu', 'fp16_gpu', 'deepspeed_optimize_model_gpu']) and not lookahead else 'N/A', | |||
| streaming if 'win' in test_api else 'N/A', | |||
| use_fp16_torch_dtype if 'pipeline_parallel_gpu' in test_api else 'N/A'], | |||
| use_fp16_torch_dtype if 'pipeline_parallel_gpu' in test_api else 'N/A', | |||
| group_size], | |||
There was a problem hiding this comment.
Should we make group_size value "N/A" for other test_api? Maybe confusing
There was a problem hiding this comment.
Good point, we will fix this in next PR . 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small bugfix
Description
1. Why the change?
2. User API changes
3. Summary of the change
4. How to test?
1234). And paste your action link here once it has been successfully finished.5. New dependencies
- Dependency1
- Dependency2
- ...
- Dependency1 and license1
- Dependency2 and license2
- ...