Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Ubuntu 22.04 builds #137

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Enable Ubuntu 22.04 builds #137

merged 4 commits into from
Nov 13, 2023

Conversation

fabianoboril
Copy link
Contributor

@fabianoboril fabianoboril commented Nov 11, 2023 •
edited by rdower
Loading

  • Updated github workflow to still build on 18.04
  • Added support for clang-10 on 20.04
  • Added support for gcc-11 and clang-14 on 22.04

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2023 •
edited
Loading

Codecov Report

Merging #137 (dd9644b) into master (a556e38) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #137   +/-   ##
=======================================
  Coverage   82.03%   82.04%           
=======================================
  Files         268      268           
  Lines       34777    34794   +17     
  Branches     6374     6385   +11     
=======================================
+ Hits        28531    28545   +14     
- Misses        803      804    +1     
- Partials     5443     5445    +2
Files Coverage Δ
...rss_map_integration/tests/RssSceneCreationTest.hpp 65.59% <ø> (ø)

... and 3 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@fabianoboril fabianoboril force-pushed the fabianoboril-patch-1 branch 6 times, most recently from b238402 to 17ffebd Compare November 12, 2023 14:38
@fabianoboril
Enable Ubuntu 22.04 builds
dbfb9ff 
* Updated github workflow to still build on 18.04
* Added support for clang-10 on 20.04
* Added support for gcc-11 and clang-14 on 22.04
@fabianoboril fabianoboril changed the title Update build_test.yml for Ubuntu 22.04 Enable Ubuntu 22.04 builds Nov 13, 2023
berndgassmann
berndgassmann approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@berndgassmann berndgassmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @fabianoboril)

berndgassmann
berndgassmann previously approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@berndgassmann berndgassmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @fabianoboril)

berndgassmann
berndgassmann approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@berndgassmann berndgassmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @fabianoboril)

@berndgassmann berndgassmann merged commit be6b68b into master Nov 13, 2023
15 checks passed
@berndgassmann berndgassmann deleted the fabianoboril-patch-1 branch November 13, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berndgassmann berndgassmann berndgassmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabianoboril @codecov-commenter @berndgassmann