Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

Update container dir name to align with deployment image names #224

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Update container dir name to align with deployment image names #224

merged 2 commits into from
Jan 3, 2024

Conversation

ruomengh
Copy link
Contributor

@ruomengh ruomengh commented Jan 3, 2024

  1. Update container dir name
  2. Update deployment guide

1. Update container dir name
2. Update deployment guide

Signed-off-by: Hao, Ruomeng <ruomeng.hao@intel.com>
@Ruoyu-y
Copy link
Contributor

Ruoyu-y commented Jan 3, 2024

One more thing need to be changed once refined the container dir name. There's a README.md file under each service folder at service/xxxx. Within that readme file, there's lines of code to guide user for image building. That part need to be changed too.
e.g.

docker build -t ccnp-eventlog-server:0.1 -f container/eventlog-server/Dockerfile .

Signed-off-by: Hao, Ruomeng <ruomeng.hao@intel.com>
@ruomengh
Copy link
Contributor Author

ruomengh commented Jan 3, 2024

One more thing need to be changed once refined the container dir name. There's a README.md file under each service folder at service/xxxx. Within that readme file, there's lines of code to guide user for image building. That part need to be changed too. e.g.

docker build -t ccnp-eventlog-server:0.1 -f container/eventlog-server/Dockerfile .

Thanks for the comments. Updated.

Copy link
Contributor

@kenplusplus kenplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenplusplus kenplusplus merged commit debc06c into intel:main Jan 3, 2024
3 checks passed
@ruomengh ruomengh deleted the update-deploy branch January 10, 2024 05:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants