-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrade from LegacyVersion #2679
Conversation
40ca8c9
to
213da83
Compare
Currently failing 12 tests:
I haven't dug into these because I'm done work for the week (and need to switch to childcare) but that's an interesting set of failures. What I've learned from playing around with this today is that LegacyVersion was hiding some interesting conversions in our data, and I'm not sure the choices I made just to get it working were exactly the ones that we had before. |
For the record: I think this PR will be replaced by something that uses cmp_version https://pypi.org/project/cmp_version/ but I need to update our licensing paperwork before that can happen. |
Closing in favour of #3430 |
Restarting the effort to handle the cases that were previously handled by LegacyVersion so we can upgrade to the latest packaging. This doens't actually work yet.