-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add latest upstream stable version in CPE summary #3267
Conversation
73e157d
to
bd3bc30
Compare
Does https://release-monitoring.org/ have any sort of data license? I can see that the code is GPLv2 but I'm not sure if that's intended to carry over to the data or not. |
bd3bc30
to
d5a8431
Compare
Infrastructure code is indeed licensed in GPLv2. However, I don't know what is the "license" of the data stored on release-monitoring.org. If this is an issue, a lawyer will probably have to reach this Fedora project. |
fa7950e
to
ac108c6
Compare
Codecov Report
@@ Coverage Diff @@
## main #3267 +/- ##
==========================================
+ Coverage 79.67% 80.06% +0.38%
==========================================
Files 758 758
Lines 11596 11616 +20
Branches 1568 1571 +3
==========================================
+ Hits 9239 9300 +61
+ Misses 1932 1897 -35
+ Partials 425 419 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ac108c6
to
f9505f9
Compare
I can split this PR in two if needed: a first one to add CPE summary with the count of CVEs for each package and an other one that adds "latest upstream version" |
I happened to chat with someone who is not a lawyer but works in similar compliance problems, and he suspects that the data we're using is too simple and machine-translatable to carry a copyright, which is maybe why it doesn't have one. But it doesn't absolve me of the responsibility of checking with our own compliance team and seeing if they want to reach out to fedora to clarify, so I'm going to flag this like a requirements change and plan to open a ticket with the right people to ask later today. |
Understood, then I opened #3277 to hopefully merge the addition of CPE summary table (but without the information on the latest stable version retrieved from release-monitoring) |
CPE summary table is updated to display the latest upstream stable version (retrieved thanks to release-monitoring project). This first iteration doesn't use a local cache and so only works in online mode. Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
f9505f9
to
3b3e5a3
Compare
Quick update on this: licensing didn't say no but they did ask me to update a bunch of paperwork, then it got put on hold while I was out sick. But it's in process, I just need to prompt them to keep it moving. |
I got a random "ok" with no explanation on my new licensing paperwork, so I think we're good to merge this. I'm going to update the branch to make sure nothing has gone awry before I do so, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like tests are mostly behaving (the fails were in the may-fail tests and a whitespace issue in gitlint that I'll fix during merge). Thank you again for this one and sorry it took so long to sort out whether I could merge it! I think a number of people will find this version info useful.
CPE summary table is updated to display the latest upstream stable version (retrieved thanks to release-monitoring project).
This first iteration doesn't use a local cache and so only works in online mode.