-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated doc strings to version_scanner.py #3417
Conversation
Hi @terriko Kindly validate and approve the PR |
I've approved the tests to run, but it looks like something went wrong with the indentation. It's unlikely we'll be able to merge this until that's fixed. Maybe a bad setting in your development tools? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking as needing changes due to indentation problems.
Codecov Report
@@ Coverage Diff @@
## main #3417 +/- ##
==========================================
- Coverage 80.21% 79.93% -0.29%
==========================================
Files 758 758
Lines 11596 11596
Branches 1568 1568
==========================================
- Hits 9302 9269 -33
- Misses 1862 1907 +45
+ Partials 432 420 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I'm going to mark this as blocked because someone else had already claimed #3378 and they've got a PR in flight already. If for some reason that one can't be merged I'll consider this one, but more likely this issue will be closed as a duplicate after that one gets merged. Feel free to work on it for practice if that's helpful anyhow, but if you're hoping to get a merged PR for hacktoberfest you should probably work on an issue not claimed by someone else. We've got lots of issues and they don't need the hacktoberfest label to count! But I did put a hacktoberfest label on this unclaimed one if you're looking for somethign to do: #3255 |
I have been using pycharm for my local development, let me retry to re-indent it. |
Kindly review the PR and approve it, Issue #3393