-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update SBOM for Python 3.8 #3449
Conversation
950a772
to
774cf95
Compare
Moment of truth for our CI changes. Closing and re-opening for tests. |
Darn, so skipping things in this way results in an un-mergeable pull request. Not the desired effect at all; I'll have to revert the other PR. |
Having the if statement at the top of the job caused a situation where the job didn't complete and the sboms could never be merged due to branch protection rules. This attempts to just skip the tests and see if that addresses the problem in a different way. Signed-off-by: Terri Oda <terri.oda@intel.com>
I'm currently playing around with some different ways to skip tests in this branch to see if we can resolve this without fully re-enabling the tests. |
Codecov Report
@@ Coverage Diff @@
## main #3449 +/- ##
==========================================
+ Coverage 74.82% 79.95% +5.12%
==========================================
Files 758 758
Lines 11616 11796 +180
Branches 1571 1624 +53
==========================================
+ Hits 8692 9431 +739
+ Misses 2581 1942 -639
- Partials 343 423 +80
Flags with carried forward coverage won't be shown. Click here to find out more. see 25 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Merging this now. This will re-enable the tests marked as required, which isn't quite what I want but it will allow me to merge the SBOMs for this week while we continue to refine the CI to avoid unnecessary testing. |
Automated changes by create-pull-request GitHub action